Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 55763002: Add a test for <dialog> in the accessibility tree (Closed)

Created:
7 years, 1 month ago by falken
Modified:
7 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a test for <dialog> in the accessibility tree This is a test for the Blink change: https://codereview.chromium.org/54373013/ BUG=264959 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232923

Patch Set 1 #

Patch Set 2 : add android expectation #

Patch Set 3 : add win expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/dialog.html View 1 chunk +8 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/dialog-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/dialog-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/dialog-expected-win.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
falken
Dominic, could you review this patch and the Blink-side one? I just need to wait ...
7 years, 1 month ago (2013-11-01 14:57:17 UTC) #1
dmazzoni
lgtm
7 years, 1 month ago (2013-11-01 15:07:59 UTC) #2
falken
On 2013/11/01 15:07:59, Dominic Mazzoni wrote: > lgtm Actually, is there a recommended way to ...
7 years, 1 month ago (2013-11-01 15:20:25 UTC) #3
dmazzoni
On 2013/11/01 15:20:25, falken wrote: > On 2013/11/01 15:07:59, Dominic Mazzoni wrote: > > lgtm ...
7 years, 1 month ago (2013-11-01 15:36:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/55763002/240001
7 years, 1 month ago (2013-11-03 04:18:39 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96931
7 years, 1 month ago (2013-11-03 07:01:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/55763002/240001
7 years, 1 month ago (2013-11-05 02:38:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/55763002/240001
7 years, 1 month ago (2013-11-05 03:18:04 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 06:00:54 UTC) #9
Message was sent while issue was closed.
Change committed as 232923

Powered by Google App Engine
This is Rietveld 408576698