Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: Source/web/ContextMenuClientImpl.cpp

Issue 557613002: Remove a part of type checking predicates of HTMLInputElement. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTheme.cpp ('k') | Source/web/WebInputElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 16 matching lines...) Expand all
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "web/ContextMenuClientImpl.h" 32 #include "web/ContextMenuClientImpl.h"
33 33
34 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 34 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
35 #include "core/CSSPropertyNames.h" 35 #include "core/CSSPropertyNames.h"
36 #include "core/HTMLNames.h" 36 #include "core/HTMLNames.h"
37 #include "core/InputTypeNames.h"
37 #include "core/css/CSSStyleDeclaration.h" 38 #include "core/css/CSSStyleDeclaration.h"
38 #include "core/dom/Document.h" 39 #include "core/dom/Document.h"
39 #include "core/dom/DocumentMarkerController.h" 40 #include "core/dom/DocumentMarkerController.h"
40 #include "core/editing/Editor.h" 41 #include "core/editing/Editor.h"
41 #include "core/editing/SpellChecker.h" 42 #include "core/editing/SpellChecker.h"
42 #include "core/frame/FrameHost.h" 43 #include "core/frame/FrameHost.h"
43 #include "core/frame/FrameView.h" 44 #include "core/frame/FrameView.h"
44 #include "core/frame/PinchViewport.h" 45 #include "core/frame/PinchViewport.h"
45 #include "core/frame/Settings.h" 46 #include "core/frame/Settings.h"
46 #include "core/html/HTMLAnchorElement.h" 47 #include "core/html/HTMLAnchorElement.h"
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 // Send the frame and page URLs in any case. 306 // Send the frame and page URLs in any case.
306 data.pageURL = urlFromFrame(m_webView->mainFrameImpl()->frame()); 307 data.pageURL = urlFromFrame(m_webView->mainFrameImpl()->frame());
307 if (selectedFrame != m_webView->mainFrameImpl()->frame()) { 308 if (selectedFrame != m_webView->mainFrameImpl()->frame()) {
308 data.frameURL = urlFromFrame(selectedFrame); 309 data.frameURL = urlFromFrame(selectedFrame);
309 RefPtr<HistoryItem> historyItem = selectedFrame->loader().currentItem(); 310 RefPtr<HistoryItem> historyItem = selectedFrame->loader().currentItem();
310 if (historyItem) 311 if (historyItem)
311 data.frameHistoryItem = WebHistoryItem(historyItem); 312 data.frameHistoryItem = WebHistoryItem(historyItem);
312 } 313 }
313 314
314 if (r.isSelected()) { 315 if (r.isSelected()) {
315 if (!isHTMLInputElement(*r.innerNonSharedNode()) || !toHTMLInputElement( r.innerNonSharedNode())->isPasswordField()) 316 if (!isHTMLInputElement(*r.innerNonSharedNode()) || toHTMLInputElement(r .innerNonSharedNode())->type() != InputTypeNames::password)
316 data.selectedText = selectedFrame->selectedText().stripWhiteSpace(); 317 data.selectedText = selectedFrame->selectedText().stripWhiteSpace();
317 } 318 }
318 319
319 if (r.isContentEditable()) { 320 if (r.isContentEditable()) {
320 data.isEditable = true; 321 data.isEditable = true;
321 322
322 // When Chrome enables asynchronous spellchecking, its spellchecker adds spelling markers to misspelled 323 // When Chrome enables asynchronous spellchecking, its spellchecker adds spelling markers to misspelled
323 // words and attaches suggestions to these markers in the background. Th erefore, when a user right-clicks 324 // words and attaches suggestions to these markers in the background. Th erefore, when a user right-clicks
324 // a mouse on a word, Chrome just needs to find a spelling marker on the word instead of spellchecking it. 325 // a mouse on a word, Chrome just needs to find a spelling marker on the word instead of spellchecking it.
325 if (selectedFrame->settings() && selectedFrame->settings()->asynchronous SpellCheckingEnabled()) { 326 if (selectedFrame->settings() && selectedFrame->settings()->asynchronous SpellCheckingEnabled()) {
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
437 outputItems[i] = subItems[i]; 438 outputItems[i] = subItems[i];
438 subMenuItems.swap(outputItems); 439 subMenuItems.swap(outputItems);
439 } 440 }
440 441
441 void ContextMenuClientImpl::populateCustomMenuItems(const ContextMenu* defaultMe nu, WebContextMenuData* data) 442 void ContextMenuClientImpl::populateCustomMenuItems(const ContextMenu* defaultMe nu, WebContextMenuData* data)
442 { 443 {
443 populateSubMenuItems(defaultMenu->items(), data->customItems); 444 populateSubMenuItems(defaultMenu->items(), data->customItems);
444 } 445 }
445 446
446 } // namespace blink 447 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTheme.cpp ('k') | Source/web/WebInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698