Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 557603002: Fix potential deadlock between Pipeline and VideoRendererImpl. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix potential deadlock between Pipeline and VideoRendererImpl. I don't believe we hit this in practice since the two lock acquiring sequences we make happen as separate tasks executed on the same thread. To summarize the ThreadSanitizer warning: - Task A acquires VideoRendererImpl -> Pipeline lock via FrameReady() -> GetMediaDuration() - Task B acquires Pipeline -> VideoRendererImpl lock via DoStop() -> ~VideoRendererImpl() Solution: don't hold onto the Pipeline lock when destroying renderers. BUG=412097 Committed: https://crrev.com/0abb84994f293d6fc17e5c2d3e21a933d4f73fbc Cr-Commit-Position: refs/heads/master@{#293890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/base/pipeline.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
scherkus (not reviewing)
6 years, 3 months ago (2014-09-09 00:54:24 UTC) #2
xhwang
lgtm!
6 years, 3 months ago (2014-09-09 00:57:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/557603002/1
6 years, 3 months ago (2014-09-09 01:09:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as abe0f231fbeb317e2fe19ae81db70014d2a6f86c
6 years, 3 months ago (2014-09-09 07:43:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0abb84994f293d6fc17e5c2d3e21a933d4f73fbc
Cr-Commit-Position: refs/heads/master@{#293890}

Powered by Google App Engine
This is Rietveld 408576698