DescriptionFix potential deadlock between Pipeline and VideoRendererImpl.
I don't believe we hit this in practice since the two lock acquiring
sequences we make happen as separate tasks executed on the same
thread.
To summarize the ThreadSanitizer warning:
- Task A acquires VideoRendererImpl -> Pipeline lock via
FrameReady() -> GetMediaDuration()
- Task B acquires Pipeline -> VideoRendererImpl lock via
DoStop() -> ~VideoRendererImpl()
Solution: don't hold onto the Pipeline lock when destroying renderers.
BUG=412097
Committed: https://crrev.com/0abb84994f293d6fc17e5c2d3e21a933d4f73fbc
Cr-Commit-Position: refs/heads/master@{#293890}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|