Clean up WebMediaPlayerAndroid needs_establish_peer_

content/renderer/media/android/webmediaplayer_android.h

Index: content/renderer/media/android/webmediaplayer_android.h
diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h
index bf290b71229ca958d8c356398b03be1238f6589e..73923062a332bde9dce2cdfc191865c950c05537 100644
--- a/content/renderer/media/android/webmediaplayer_android.h
+++ b/content/renderer/media/android/webmediaplayer_android.h
@@ -266,12 +266,9 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
   void TryCreateStreamTextureProxyIfNeeded();
   void DoCreateStreamTexture();
 
-  // Helper method to reestablish the surface texture peer for android
-  // media player.
-  void EstablishSurfaceTexturePeer();
-
-  // Requesting whether the surface texture peer needs to be reestablished.
-  void SetNeedsEstablishPeer(bool needs_establish_peer);
+  // This method is meant to be idempotent. Should be called whenever any of
+  // conditions chances and it is ok to establish peer.

[qinmin, 2014/09/09 22:13:41]

s/chances/change/

[boliu, 2014/09/09 22:35:14]

Done.

+  void EstablishSurfaceTexturePeerIfNeeded();
 
  private:
   void InitializePlayer(const GURL& url,
@@ -408,7 +405,8 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
   bool is_playing_;
 
   // Whether media player needs to re-establish the surface texture peer.
-  bool needs_establish_peer_;
+  bool peer_established_;

[qinmin, 2014/09/09 22:13:41]

this is a poor variable name, we never know whether peer is established or not.
When we set this to true, we just send an IPC, and no idea whether browser side
will establish the peer or not. And the comments on the variable is not fixed.

[boliu, 2014/09/09 22:35:14]

Renamed it back to needs_establish_peer_ as I can't think of a better name.
Which means every single condition is inverted.

Added more comment on how this should be used.

+  bool in_fullscreen_;
 
   // Whether |stream_texture_proxy_| is initialized.
   bool stream_texture_proxy_initialized_;