Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 557593002: Clean up WebMediaPlayerAndroid needs_establish_peer_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/webmediaplayer_android.h
diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h
index bf290b71229ca958d8c356398b03be1238f6589e..73923062a332bde9dce2cdfc191865c950c05537 100644
--- a/content/renderer/media/android/webmediaplayer_android.h
+++ b/content/renderer/media/android/webmediaplayer_android.h
@@ -266,12 +266,9 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
void TryCreateStreamTextureProxyIfNeeded();
void DoCreateStreamTexture();
- // Helper method to reestablish the surface texture peer for android
- // media player.
- void EstablishSurfaceTexturePeer();
-
- // Requesting whether the surface texture peer needs to be reestablished.
- void SetNeedsEstablishPeer(bool needs_establish_peer);
+ // This method is meant to be idempotent. Should be called whenever any of
+ // conditions chances and it is ok to establish peer.
+ void EstablishSurfaceTexturePeerIfNeeded();
private:
void InitializePlayer(const GURL& url,
@@ -408,7 +405,8 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
bool is_playing_;
// Whether media player needs to re-establish the surface texture peer.
- bool needs_establish_peer_;
+ bool peer_established_;
+ bool in_fullscreen_;
// Whether |stream_texture_proxy_| is initialized.
bool stream_texture_proxy_initialized_;

Powered by Google App Engine
This is Rietveld 408576698