Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: sdk/lib/_internal/pub_generated/test/validator/name_test.dart

Issue 557563002: Store the async-await compiled pub code directly in the repo. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/test/validator/name_test.dart
diff --git a/sdk/lib/_internal/pub/test/validator/name_test.dart b/sdk/lib/_internal/pub_generated/test/validator/name_test.dart
similarity index 62%
copy from sdk/lib/_internal/pub/test/validator/name_test.dart
copy to sdk/lib/_internal/pub_generated/test/validator/name_test.dart
index 17a460fe02e3a5bef7f3ef78d26ee2e8749bfae7..318a665a04f7bbf9e28a213995a84a29f8460fc0 100644
--- a/sdk/lib/_internal/pub/test/validator/name_test.dart
+++ b/sdk/lib/_internal/pub_generated/test/validator/name_test.dart
@@ -1,10 +1,5 @@
-// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
import 'package:path/path.dart' as path;
import 'package:scheduled_test/scheduled_test.dart';
-
import '../../lib/src/entrypoint.dart';
import '../../lib/src/io.dart';
import '../../lib/src/validator.dart';
@@ -12,105 +7,93 @@ import '../../lib/src/validator/name.dart';
import '../descriptor.dart' as d;
import '../test_pub.dart';
import 'utils.dart';
-
Validator name(Entrypoint entrypoint) => new NameValidator(entrypoint);
-
main() {
initConfig();
-
group('should consider a package valid if it', () {
setUp(d.validPackage.create);
-
integration('looks normal', () => expectNoValidationError(name));
-
integration('has a badly-named library in lib/src', () {
- d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0"),
- d.dir("lib", [
- d.file("test_pkg.dart", "int i = 1;"),
- d.dir("src", [d.file("8ball.dart", "int j = 2;")])
- ])
- ]).create();
+ d.dir(
+ appPath,
+ [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir(
+ "lib",
+ [
+ d.file("test_pkg.dart", "int i = 1;"),
+ d.dir("src", [d.file("8ball.dart", "int j = 2;")])])]).create();
expectNoValidationError(name);
});
-
integration('has a name that starts with an underscore', () {
- d.dir(appPath, [
- d.libPubspec("_test_pkg", "1.0.0"),
- d.dir("lib", [
- d.file("_test_pkg.dart", "int i = 1;")
- ])
- ]).create();
+ d.dir(
+ appPath,
+ [
+ d.libPubspec("_test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("_test_pkg.dart", "int i = 1;")])]).create();
expectNoValidationError(name);
});
});
-
group('should consider a package invalid if it', () {
setUp(d.validPackage.create);
-
integration('has an empty package name', () {
d.dir(appPath, [d.libPubspec("", "1.0.0")]).create();
expectValidationError(name);
});
-
integration('has a package name with an invalid character', () {
d.dir(appPath, [d.libPubspec("test-pkg", "1.0.0")]).create();
expectValidationError(name);
});
-
integration('has a package name that begins with a number', () {
d.dir(appPath, [d.libPubspec("8ball", "1.0.0")]).create();
expectValidationError(name);
});
-
integration('has a package name that contains upper-case letters', () {
d.dir(appPath, [d.libPubspec("TestPkg", "1.0.0")]).create();
expectValidationWarning(name);
});
-
integration('has a package name that is a Dart reserved word', () {
d.dir(appPath, [d.libPubspec("final", "1.0.0")]).create();
expectValidationError(name);
});
-
integration('has a library name with an invalid character', () {
- d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0"),
- d.dir("lib", [d.file("test-pkg.dart", "int i = 0;")])
- ]).create();
+ d.dir(
+ appPath,
+ [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("test-pkg.dart", "int i = 0;")])]).create();
expectValidationWarning(name);
});
-
integration('has a library name that begins with a number', () {
- d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0"),
- d.dir("lib", [d.file("8ball.dart", "int i = 0;")])
- ]).create();
+ d.dir(
+ appPath,
+ [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("8ball.dart", "int i = 0;")])]).create();
expectValidationWarning(name);
});
-
integration('has a library name that contains upper-case letters', () {
- d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0"),
- d.dir("lib", [d.file("TestPkg.dart", "int i = 0;")])
- ]).create();
+ d.dir(
+ appPath,
+ [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("TestPkg.dart", "int i = 0;")])]).create();
expectValidationWarning(name);
});
-
integration('has a library name that is a Dart reserved word', () {
- d.dir(appPath, [
- d.libPubspec("test_pkg", "1.0.0"),
- d.dir("lib", [d.file("for.dart", "int i = 0;")])
- ]).create();
+ d.dir(
+ appPath,
+ [
+ d.libPubspec("test_pkg", "1.0.0"),
+ d.dir("lib", [d.file("for.dart", "int i = 0;")])]).create();
expectValidationWarning(name);
});
-
integration('has a single library named differently than the package', () {
- schedule(() =>
- deleteEntry(path.join(sandboxDir, appPath, "lib", "test_pkg.dart")));
- d.dir(appPath, [
- d.dir("lib", [d.file("best_pkg.dart", "int i = 0;")])
- ]).create();
+ schedule(
+ () => deleteEntry(path.join(sandboxDir, appPath, "lib", "test_pkg.dart")));
+ d.dir(
+ appPath,
+ [d.dir("lib", [d.file("best_pkg.dart", "int i = 0;")])]).create();
expectValidationWarning(name);
});
});

Powered by Google App Engine
This is Rietveld 408576698