Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 557553002: Fix chrome://extensions checkboxes (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix chrome://extensions checkboxes 1. fix vertical alignment 2. fix text overlap in Hindi 3. fix text measuring function for Hindi (so the checkbox stays in one place when you check and uncheck it) BUG=411805 Committed: https://crrev.com/63f76caebfb34a72608f8c8e12cf5e466ba9e0cb Cr-Commit-Position: refs/heads/master@{#293862}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/extensions/extensions.css View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
6 years, 3 months ago (2014-09-08 22:39:21 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/557553002/diff/1/chrome/browser/resources/extensions/extensions.js File chrome/browser/resources/extensions/extensions.js (right): https://codereview.chromium.org/557553002/diff/1/chrome/browser/resources/extensions/extensions.js#newcode439 chrome/browser/resources/extensions/extensions.js:439: measuringDiv.className = 'enable-text'; nit: this looks like a ...
6 years, 3 months ago (2014-09-08 22:47:11 UTC) #3
Evan Stade
https://codereview.chromium.org/557553002/diff/1/chrome/browser/resources/extensions/extensions.js File chrome/browser/resources/extensions/extensions.js (right): https://codereview.chromium.org/557553002/diff/1/chrome/browser/resources/extensions/extensions.js#newcode439 chrome/browser/resources/extensions/extensions.js:439: measuringDiv.className = 'enable-text'; On 2014/09/08 22:47:11, Dan Beam wrote: ...
6 years, 3 months ago (2014-09-08 22:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/557553002/1
6 years, 3 months ago (2014-09-08 22:50:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as dfefe835c9bf44c711e7cc467e2cd647fb1f651e
6 years, 3 months ago (2014-09-09 06:05:31 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:50:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63f76caebfb34a72608f8c8e12cf5e466ba9e0cb
Cr-Commit-Position: refs/heads/master@{#293862}

Powered by Google App Engine
This is Rietveld 408576698