Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 557523002: Add keyboard handler for mime-handler-view. (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add keyboard handler for mime-handler-view. BUG=411753 Test=With mime handler view turned on, click on a PDF to focus the plugin, now send some keyboard event, like CTRL+L. See the keyboard event work, i.e. the chrome address bar gets focus. Committed: https://crrev.com/3895fc1cf74afc344677112d00ad31b0d3311807 Cr-Commit-Position: refs/heads/master@{#293868}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +16 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
lazyboy
https://chromiumcodereview.appspot.com/557523002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://chromiumcodereview.appspot.com/557523002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode107 extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:107: // additional key events. This needs to be fixed ...
6 years, 3 months ago (2014-09-08 21:48:36 UTC) #2
Fady Samuel
LGTM https://codereview.chromium.org/557523002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/557523002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode107 extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:107: // additional key events. This needs to be ...
6 years, 3 months ago (2014-09-08 21:51:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/557523002/1
6 years, 3 months ago (2014-09-08 21:56:49 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-09 05:13:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/557523002/1
6 years, 3 months ago (2014-09-09 05:31:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 37f1bd32522c1afa72eaf6a37143d82bffa3a0fe
6 years, 3 months ago (2014-09-09 06:20:53 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3895fc1cf74afc344677112d00ad31b0d3311807
Cr-Commit-Position: refs/heads/master@{#293868}

Powered by Google App Engine
This is Rietveld 408576698