Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 557493002: Fix uninitialized member from PageIndicator::PageIndicator(). (Closed)

Created:
6 years, 3 months ago by Tom Sepez
Modified:
6 years, 3 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized member from PageIndicator::PageIndicator(). Per msan report, the line in question reads: if (timer_id == fade_out_timer_id_) { so initialize fade_out_timer_id_ in the constructor. BUG=411177 Committed: https://crrev.com/f4680290857fdc78eb9ff79305aead08b29d56ca Cr-Commit-Position: refs/heads/master@{#294055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pdf/page_indicator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Tom Sepez
Gene, please review. Thanks.
6 years, 3 months ago (2014-09-08 20:56:08 UTC) #2
gene
lgtm
6 years, 3 months ago (2014-09-08 21:06:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/557493002/1
6 years, 3 months ago (2014-09-08 21:24:30 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-09 05:05:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/557493002/1
6 years, 3 months ago (2014-09-10 00:06:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 069ea176275c9adc81e5f23bf3044c593f722259
6 years, 3 months ago (2014-09-10 00:52:46 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4680290857fdc78eb9ff79305aead08b29d56ca
Cr-Commit-Position: refs/heads/master@{#294055}

Powered by Google App Engine
This is Rietveld 408576698