Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 557483002: Remove last use of WebFrame::isLoading() (Closed)

Created:
6 years, 3 months ago by Nate Chapin
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove last use of WebFrame::isLoading() All other uses are from a WebLocalFrame, and the concept is local-specific. This will enable us to move it to WebLocalFrame in the blink repo. BUG= Committed: https://crrev.com/02cfd5ccc819ce649db8ff032d43fb16ee3167d9 Cr-Commit-Position: refs/heads/master@{#293869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nate Chapin
6 years, 3 months ago (2014-09-08 20:00:58 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-08 23:20:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/557483002/1
6 years, 3 months ago (2014-09-08 23:29:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 11a9c50dc0826a48e83b6d22ffbcde0333ba7d57
6 years, 3 months ago (2014-09-09 06:21:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02cfd5ccc819ce649db8ff032d43fb16ee3167d9
Cr-Commit-Position: refs/heads/master@{#293869}

Powered by Google App Engine
This is Rietveld 408576698