Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 557473002: Add working realpath implementation to glibc-compat (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add working realpath implementation to glibc-compat This is a temporary measure that can be removed once a working realpath is added to libnacl. This is needed in order to run the libgit2 tests under sel_ldr. R=binji@chromium.org Committed: https://code.google.com/p/naclports/source/detail?r=1636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -5 lines) Patch
M ports/glibc-compat/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A ports/glibc-compat/src/realpath.c View 1 chunk +124 lines, -0 lines 0 comments Download
M ports/glibc-compat/src/stubs.c View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sam Clegg
6 years, 3 months ago (2014-09-08 18:25:17 UTC) #2
binji
lgtm, could you mention in the CL what port this is needed for?
6 years, 3 months ago (2014-09-08 18:30:28 UTC) #3
Sam Clegg
6 years, 3 months ago (2014-09-08 19:41:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1636.

Powered by Google App Engine
This is Rietveld 408576698