Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 557463002: Make base_unittests_apk actually work (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
Reviewers:
rlarocque, brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-group-datadeps
Project:
chromium
Visibility:
Public.

Description

Make base_unittests_apk actually work This changes the "test" template to create a shared_library (instead of an executable) on Android. After this, we can actually run base_unittests with `build/android/test_runner.py gtest -s base_unnittests` as normal (though may need to CHROMIUM_OUT_DIR and BUILDTYPE as appropriate). This requires adding the following targets: //testing/android:native_test_native_code //testing/android:native_test_util //testing/android:native_test_jni_headers //tools/android/md5sum:md5sum //tools/android/md5sum:md5sum_bin //tools/android/md5sum:md5sum_prepare_dist //tools/android/md5sum:md5sum_copy_host Also, makes it so that native executables are stripped (just like shared libraries). Adds a simple create_native_execuatable_dist template that sets up a dist directory for the executable (see build/android/gyp/native_app_dependencies.gyp). BUG=359249 TBR=rlarocque Committed: https://crrev.com/e65ead8fb1a1976682356cf824445476584e70f0 Cr-Commit-Position: refs/heads/master@{#294032}

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -47 lines) Patch
M base/BUILD.gn View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/android/gyp/write_ordered_libraries.py View 2 chunks +7 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +8 lines, -4 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 4 chunks +85 lines, -41 lines 0 comments Download
M build/config/android/rules.gni View 1 3 chunks +81 lines, -1 line 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 2 chunks +9 lines, -0 lines 0 comments Download
M sync/test/accounts_client/test_accounts_client_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
A testing/android/BUILD.gn View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
M testing/android/native_test.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
A tools/android/md5sum/BUILD.gn View 1 chunk +53 lines, -0 lines 0 comments Download
M tools/android/md5sum/md5sum.gyp View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
cjhopman
brettw: * https://codereview.chromium.org/557463002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/557463002/diff/1/build/config/BUILDCONFIG.gn#newcode500 build/config/BUILDCONFIG.gn:500: # The sources assignment filter will have ...
6 years, 3 months ago (2014-09-08 18:09:45 UTC) #2
brettw
lgtm https://codereview.chromium.org/557463002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/557463002/diff/1/build/config/BUILDCONFIG.gn#newcode404 build/config/BUILDCONFIG.gn:404: set_defaults("test") { I think you will need to ...
6 years, 3 months ago (2014-09-08 20:04:22 UTC) #3
cjhopman
https://codereview.chromium.org/557463002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/557463002/diff/1/build/config/BUILDCONFIG.gn#newcode404 build/config/BUILDCONFIG.gn:404: set_defaults("test") { On 2014/09/08 20:04:22, brettw wrote: > I ...
6 years, 3 months ago (2014-09-09 16:55:32 UTC) #4
cjhopman
rlarocque: sync/
6 years, 3 months ago (2014-09-09 16:56:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/557463002/60001
6 years, 3 months ago (2014-09-09 21:22:07 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 37ee9f0e2219611793c5a4dcf846760177473b52
6 years, 3 months ago (2014-09-09 23:23:56 UTC) #11
Dirk Pranke
On 2014/09/09 23:23:56, I haz the power (commit-bot) wrote: > Committed patchset #4 (id:60001) as ...
6 years, 3 months ago (2014-09-09 23:32:50 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:26 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e65ead8fb1a1976682356cf824445476584e70f0
Cr-Commit-Position: refs/heads/master@{#294032}

Powered by Google App Engine
This is Rietveld 408576698