Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 557393003: Introduce AccessibilityFocusRing. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
aboxhall+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, stevenjb+watch_chromium.org, yuzo+watch_chromium.org, Chirantan Ekbote
Base URL:
https://chromium.googlesource.com/chromium/src.git@accessibility_private_histograms
Project:
chromium
Visibility:
Public.

Description

Introduce AccessibilityFocusRing. BUG=314889 Committed: https://crrev.com/65ea5c02e5f0334c73763c8f94704dd2bb67b6fc Cr-Commit-Position: refs/heads/master@{#294510}

Patch Set 1 #

Total comments: 26

Patch Set 2 : Address feedback #

Total comments: 4

Patch Set 3 : Address last feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+847 lines, -14 lines) Patch
A chrome/browser/chromeos/ui/accessibility_focus_ring.h View 1 chunk +89 lines, -0 lines 1 comment Download
A chrome/browser/chromeos/ui/accessibility_focus_ring.cc View 1 1 chunk +119 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ui/accessibility_focus_ring_controller.h View 1 1 chunk +68 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc View 1 1 chunk +247 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc View 1 2 1 chunk +131 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.h View 1 2 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.cc View 1 2 2 chunks +12 lines, -7 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
dmazzoni
6 years, 3 months ago (2014-09-10 21:32:02 UTC) #2
xiyuan
https://codereview.chromium.org/557393003/diff/1/chrome/browser/chromeos/ui/accessibility_focus_ring.cc File chrome/browser/chromeos/ui/accessibility_focus_ring.cc (right): https://codereview.chromium.org/557393003/diff/1/chrome/browser/chromeos/ui/accessibility_focus_ring.cc#newcode14 chrome/browser/chromeos/ui/accessibility_focus_ring.cc:14: gfx::Rect body(bounds.x(), bounds.y() + bounds.height() / 4, nit: bounds.y() ...
6 years, 3 months ago (2014-09-11 03:33:11 UTC) #3
xiyuan
https://codereview.chromium.org/557393003/diff/1/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc File chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc (right): https://codereview.chromium.org/557393003/diff/1/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc#newcode102 chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc:102: aura::Window* root_window = ash::Shell::GetPrimaryRootWindow(); Primary root window might not ...
6 years, 3 months ago (2014-09-11 03:57:45 UTC) #4
dmazzoni
https://codereview.chromium.org/557393003/diff/1/chrome/browser/chromeos/ui/accessibility_focus_ring.cc File chrome/browser/chromeos/ui/accessibility_focus_ring.cc (right): https://codereview.chromium.org/557393003/diff/1/chrome/browser/chromeos/ui/accessibility_focus_ring.cc#newcode14 chrome/browser/chromeos/ui/accessibility_focus_ring.cc:14: gfx::Rect body(bounds.x(), bounds.y() + bounds.height() / 4, On 2014/09/11 ...
6 years, 3 months ago (2014-09-11 21:44:39 UTC) #5
xiyuan
lgtm https://codereview.chromium.org/557393003/diff/20001/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h File chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h (right): https://codereview.chromium.org/557393003/diff/20001/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h#newcode12 chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h:12: class Layer; This can go too. https://codereview.chromium.org/557393003/diff/20001/chrome/browser/chromeos/ui/focus_ring_layer.h File ...
6 years, 3 months ago (2014-09-11 21:56:05 UTC) #6
dmazzoni
https://codereview.chromium.org/557393003/diff/20001/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h File chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h (right): https://codereview.chromium.org/557393003/diff/20001/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h#newcode12 chrome/browser/chromeos/ui/accessibility_focus_ring_layer.h:12: class Layer; On 2014/09/11 21:56:05, xiyuan wrote: > This ...
6 years, 3 months ago (2014-09-11 22:14:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557393003/40001
6 years, 3 months ago (2014-09-11 22:23:57 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as fc771016d48231d2767ef579612f2103ec1e9384
6 years, 3 months ago (2014-09-12 00:52:28 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/65ea5c02e5f0334c73763c8f94704dd2bb67b6fc Cr-Commit-Position: refs/heads/master@{#294510}
6 years, 3 months ago (2014-09-12 00:55:06 UTC) #11
Chirantan Ekbote
https://codereview.chromium.org/557393003/diff/40001/chrome/browser/chromeos/ui/accessibility_focus_ring.h File chrome/browser/chromeos/ui/accessibility_focus_ring.h (right): https://codereview.chromium.org/557393003/diff/40001/chrome/browser/chromeos/ui/accessibility_focus_ring.h#newcode47 chrome/browser/chromeos/ui/accessibility_focus_ring.h:47: // / \ This is a pretty diagram but ...
6 years, 3 months ago (2014-09-12 02:39:13 UTC) #12
dmazzoni
On 2014/09/12 02:39:13, chirantan wrote: > https://codereview.chromium.org/557393003/diff/40001/chrome/browser/chromeos/ui/accessibility_focus_ring.h > File chrome/browser/chromeos/ui/accessibility_focus_ring.h (right): > > https://codereview.chromium.org/557393003/diff/40001/chrome/browser/chromeos/ui/accessibility_focus_ring.h#newcode47 > ...
6 years, 3 months ago (2014-09-12 17:27:10 UTC) #13
dmazzoni
6 years, 3 months ago (2014-09-12 17:31:45 UTC) #14
Message was sent while issue was closed. 
Fix for multi-line comment: https://codereview.chromium.org/568853002/

Powered by Google App Engine
This is Rietveld 408576698