Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 557363003: Allow number of open QUIC streams to grow 10% beyond configured limit at (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
rjshade, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@change_initial_RTT_estimate_75389539
Project:
chromium
Visibility:
Public.

Description

Allow number of open QUIC streams to grow 10% beyond configured limit at the QUIC internal server before closing connection. In the following situation Chrome may open more streams than the configured limit: * opens kMaxStreams streams * sends a FIN for one of the streams, now has kMaxStreams-1 streams open * opens a new stream * FIN gets lost on way to QUIC internal server * QUIC internal server terminates connection when new stream packet arrives Rather than making Chrome keep track of when the server has acknowledged a FIN, just give 10% breathing room which should avoid this case. Merge internal change: 75393293 R=rch@chromium.org, rjshade@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -21 lines) Patch
M net/quic/quic_config.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_session.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +17 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 2 chunks +55 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 3 months ago (2014-09-15 19:49:41 UTC) #1
Ryan Hamilton
6 years, 3 months ago (2014-09-15 21:43:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698