Fix iteration bounds of Android GL API initialization

Fix iteration bounds of Android GL API initialization

A dormant error in https://codereview.chromium.org/319043005 was
exposed on some new platforms; this makes sure loop iterations
are bounded.

BUG=skia:2923
R=joshualitt@google.com

Committed: https://skia.googlesource.com/skia/+/579b4fb92e78634c84670f0e09844de0478f8ffe

[tomhudson, 2014-09-10 15:14:35]

Off to trybots; meanwhile PTAL?

[joshua.litt, 2014-09-10 15:24:17]

joshualitt@chromium.org changed reviewers:
+ joshualitt@chromium.org

[joshua.litt, 2014-09-10 15:24:18]

https://codereview.chromium.org/557363002/diff/1/src/gpu/gl/android/SkNativeG...
File src/gpu/gl/android/SkNativeGLContext_android.cpp (right):

https://codereview.chromium.org/557363002/diff/1/src/gpu/gl/android/SkNativeG...
src/gpu/gl/android/SkNativeGLContext_android.cpp:95: for (size_t api = 0; NULL
== interface && api < apiLimit; ++api) {
I think we still want the value of api from above here, ie to allow for forced
gl initialization of a particular version.

[tomhudson, 2014-09-10 17:27:08]

Removed the second declaration of API, so now if the forcedGpuAPI tells us to
skip to GLES we do so.

[joshualitt, 2014-09-10 17:33:43]

On 2014/09/10 17:27:08, tomhudson wrote:
> Removed the second declaration of API, so now if the forcedGpuAPI tells us to
> skip to GLES we do so.

lgtm

[tomhudson, 2014-09-10 17:36:40]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2014-09-10 17:36:52]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/tomhudson@google.com/557363002/20001

[commit-bot: I haz the power, 2014-09-10 17:36:53]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-10 23:36 UTC

[djsollen, 2014-09-10 17:44:28]

djsollen@google.com changed reviewers:
+ djsollen@google.com

[djsollen, 2014-09-10 17:44:28]

rubber stamp lgtm

[commit-bot: I haz the power, 2014-09-10 17:45:45]

Committed patchset #2 (id:20001) as 579b4fb92e78634c84670f0e09844de0478f8ffe