Remove the assumption about client_id from gpu memory buffer allocation on the browser side.

Remove the assumption about client_id from gpu memory buffer allocation on the browser side.

BUG=

Committed: https://crrev.com/ce18d4bb587a41f42c7673cce654aa8b8805061d
Cr-Commit-Position: refs/heads/master@{#294199}

[alexst (slow to review), 2014-09-10 14:53:31]

alexst@chromium.org changed reviewers:
+ reveman@chromium.org

[alexst (slow to review), 2014-09-10 14:55:08]

Dave, this is a follow up to yersterday's CL.

Let's remove the assumption and plumb the client id since we now allow for GPU
allocation from the browser.

[reveman, 2014-09-10 16:10:14]

Thanks! lgtm with some name adjustments and updated comments.

https://codereview.chromium.org/557353002/diff/1/content/browser/gpu/browser_...
File content/browser/gpu/browser_gpu_channel_host_factory.cc (right):

https://codereview.chromium.org/557353002/diff/1/content/browser/gpu/browser_...
content/browser/gpu/browser_gpu_channel_host_factory.cc:60: int gpu_client_id;
nit: s/gpu_client_id/client_id/

https://codereview.chromium.org/557353002/diff/1/content/common/gpu/client/gp...
File content/common/gpu/client/gpu_memory_buffer_impl.h (right):

https://codereview.chromium.org/557353002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl.h:26: // |usage|.
Please update this comment. Something along the lines of. "for |usage| by
current process and |client_id|"

https://codereview.chromium.org/557353002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl.h:30: int gpu_client_id,
Sorry, I'd prefer "client_id" rather than gpu_client_id here and in all
GpuMemoryBuffer related classes as this code should not really be aware of a GPU
"process". This is just some opaque client ID as for as this code cares.

https://codereview.chromium.org/557353002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl.h:34: // by |child_process|
identified by |child_id|. The |handle| returned can be
I think we should change "for |usage| by |child_process| identified by
|child_id|" to "for |usage| by |child_process| and |child_client_id|" and not
make the assumption that there's one client_id per child process.

https://codereview.chromium.org/557353002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl.h:40: int child_id,
Please s/child_id/child_client_id/ to make the connection between this and
client_id above clear.

[alexst (slow to review), 2014-09-10 16:46:46]

Patchset #2 (id:20001) has been deleted

[alexst (slow to review), 2014-09-10 16:50:34]

alexst@chromium.org changed reviewers:
+ piman@chromium.org

[alexst (slow to review), 2014-09-10 16:50:34]

+piman for owner review on cleanup.

[piman, 2014-09-10 17:27:53]

lgtm

[alexst (slow to review), 2014-09-10 17:32:55]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-09-10 17:34:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alexst@chromium.org/557353002/40001

[commit-bot: I haz the power, 2014-09-10 18:43:19]

Committed patchset #2 (id:40001) as 2a78704e8879156a016086622059779e3a04aea1

[commit-bot: I haz the power, 2014-09-10 18:46:56]

Patchset 2 (id:??) landed as
https://crrev.com/ce18d4bb587a41f42c7673cce654aa8b8805061d
Cr-Commit-Position: refs/heads/master@{#294199}