Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 557333007: Give asan/win bot a very generous timeout. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Give asan/win bot a very generous timeout. The previous increase in r293993 didn't help anything; make the timeout really large to make sure that things aren't just slow. (Once this hasn't helped either, we're going to remove this win/asan special case.) BUG=412471 TBR=timurrrr@chromium.org NOTRY=true Committed: https://crrev.com/207907c24b8cee246ff713342a1055277b64355d Cr-Commit-Position: refs/heads/master@{#294242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/test/test_timeouts.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Nico
6 years, 3 months ago (2014-09-10 21:51:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/557333007/1
6 years, 3 months ago (2014-09-10 22:02:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3ce99a8871aa04557e7faf76d87b905f3fdce517
6 years, 3 months ago (2014-09-10 22:15:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/207907c24b8cee246ff713342a1055277b64355d Cr-Commit-Position: refs/heads/master@{#294242}
6 years, 3 months ago (2014-09-10 22:26:27 UTC) #5
Timur Iskhodzhanov
LGTM, though it didn't help :(
6 years, 3 months ago (2014-09-11 13:54:07 UTC) #6
Timur Iskhodzhanov
As per crbug.com/412471 this was not related to timeouts, maybe it's time to revert this ...
5 years, 11 months ago (2015-01-15 18:10:22 UTC) #7
Nico
5 years, 11 months ago (2015-01-15 18:14:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/828403005/ by thakis@chromium.org.

The reason for reverting is: Didn't help, wasn't the cause (see bug)..

Powered by Google App Engine
This is Rietveld 408576698