Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 557283002: Do not use a Blink feature flag for Manifest. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+prerender_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Do not use a Blink feature flag for Manifest. BUG=366145 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-10 09:35:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-10 09:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/557283002/1
6 years, 3 months ago (2014-09-10 09:51:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181725
6 years, 3 months ago (2014-09-10 10:39:35 UTC) #6
Mike West
Hrm. Is there a Chromium-side flag? I didn't think we were planning on shipping Manifest ...
6 years, 3 months ago (2014-09-10 11:06:13 UTC) #8
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-10 11:08:46 UTC) #9
Message was sent while issue was closed.
On 2014/09/10 11:06:13, Mike West wrote:
> Hrm. Is there a Chromium-side flag? I didn't think we were planning on
shipping
> Manifest yet.

The manifest is only handled on-demand for the moment so features using it will
have a flag until they ship I assume.

Powered by Google App Engine
This is Rietveld 408576698