Files.app: Remove getDriveFiles function from the private API.

Files.app: Remove getDriveFiles function from the private API.

The API is for ensuring the files are downloaded in local storage, and wad used in two places in Files.app.

The first is mounting ZIP. We don't need to care about it. We can mount ZIP
without downloading it in advance.

The second is selecting files in the file select dialog. We can download files
when fileManagerPrivate.selectFiles(s), and UI shows the progress correctly. But
previously, if downloading is cancelled, the API is regarded as success and it
passes the selected file inforamtion to the browser. The CL handles the case and
has the API report an error if the downloading is cancelled.

BUG=326082
TEST=delete cache, open the file in the file select dialog. Also cancel uploading in the dialog.

Committed: https://crrev.com/ac9bfb77a50d08037bf8d7890048e981dd06f2ae
Cr-Commit-Position: refs/heads/master@{#294320}

[hirono, 2014-09-10 07:31:14]

hirono@chromium.org changed reviewers:
+ kinaba@chromium.org

[hirono, 2014-09-10 07:31:14]

PTAL the CL? Thank you!

[kinaba, 2014-09-10 08:03:52]

Nice clean up. lgtm.

I worry a bit about the zip mounting case (it lets the user wait with little
feedback until the file is downloaded), but it has been always like that already
before the removal by this CL. I hope it will be addressed by the coming
fsp-based implementation.

https://codereview.chromium.org/557223003/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc
(right):

https://codereview.chromium.org/557223003/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc:101: if
(files.size() == 0) {
files.empty()

[hirono, 2014-09-10 13:15:24]

Patchset #6 (id:100001) has been deleted

[hirono, 2014-09-10 13:15:32]

Patchset #5 (id:80001) has been deleted

[hirono, 2014-09-10 13:17:44]

hirono@chromium.org changed reviewers:
+ benwells@chromium.org

[hirono, 2014-09-10 13:17:45]

We have the same problem when we open a drive file by packaged apps. We need
handle it in the future. Thank you.

@benwells - PTAL file_manager_private.idl? Thank you!

https://codereview.chromium.org/557223003/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc
(right):

https://codereview.chromium.org/557223003/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc:101: if
(files.size() == 0) {
On 2014/09/10 08:03:52, kinaba wrote:
> files.empty()

Done.

[benwells, 2014-09-11 01:29:50]

lgtm

[hirono, 2014-09-11 03:00:33]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-09-11 03:04:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/557223003/120001

[commit-bot: I haz the power, 2014-09-11 04:10:04]

Committed patchset #5 (id:120001) as 5c62f2f5dcc0b4cb46e88ea66a23af973d51c036

[commit-bot: I haz the power, 2014-09-11 04:12:34]

Patchset 5 (id:??) landed as
https://crrev.com/ac9bfb77a50d08037bf8d7890048e981dd06f2ae
Cr-Commit-Position: refs/heads/master@{#294320}