Added core and modules to binding tests results for binding modularization.

Added core and modules to binding tests results for binding modularization.

Updated main.py to support core/modules results.
Moved all current test results into Source/bindings/tests/results/core.
Added TestInterface5.idl to tests/idls/modules and V8TestInterface5.{h,cpp} to tests/results/modules.

BUG=358074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181720

[tasak, 2014-09-10 05:21:48]

Patchset #2 (id:10001) has been deleted

[tasak, 2014-09-10 05:22:53]

Patchset #2 (id:10001) has been deleted

[tasak, 2014-09-10 05:49:46]

Patchset #1 (id:1) has been deleted

[tasak, 2014-09-10 05:55:50]

tasak@google.com changed reviewers:
+ bashi@chromium.org, haraken@chromium.org

[tasak, 2014-09-10 05:55:53]

Would you review this CL?

https://codereview.chromium.org/557203002/diff/30001/Source/bindings/tests/re...
File Source/bindings/tests/results/modules/V8TestInterface5.cpp (right):

https://codereview.chromium.org/557203002/diff/30001/Source/bindings/tests/re...
Source/bindings/tests/results/modules/V8TestInterface5.cpp:16: #include
"bindings/tests/v8/V8Iterator.h"
I think, this should be "bindings/tests/core/v8/V8Iterator.h"?
I will fix this in another CL.

https://codereview.chromium.org/557203002/diff/30001/Source/bindings/tests/re...
Source/bindings/tests/results/modules/V8TestInterface5.cpp:17: #include
"bindings/tests/v8/V8TestInterface5.h"
"bindings/tests/modules/v8/V8TestInterface5.h"

https://codereview.chromium.org/557203002/diff/30001/Source/bindings/tests/re...
Source/bindings/tests/results/modules/V8TestInterface5.cpp:18: #include
"bindings/tests/v8/V8TestInterfaceEmpty.h"
"bindings/tests/core/v8/V8TestInterfaceEmpty.h"

[haraken, 2014-09-10 07:11:14]

LGTM, but let's wait for review of bashi-san.

> Source/bindings/tests/results/modules/V8TestInterface5.cpp:16: #include
> "bindings/tests/v8/V8Iterator.h"
> I think, this should be "bindings/tests/core/v8/V8Iterator.h"?
> I will fix this in another CL.

It's not nice to leave wrong file paths but would be OK as long as you fix it in
a reasonable timeline because the issue just happens in run-bindings-tests.

[bashi, 2014-09-10 07:39:53]

LGTM with some nits.

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
File Tools/Scripts/webkitpy/bindings/main.py (right):

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:133: def listfiles(directory):
listfiles -> list_files

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:198: def no_excess_files():
You call listfiles() twice here. Maybe good to store the result in a local
variable.

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:217: def makedir(path):
Use os.path.exists() and os.makedirs().

if not os.path.exists(path):
  os.makedirs(path)

And maybe inline.

[tasak, 2014-09-10 08:27:18]

Thank you for reviewing.

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
File Tools/Scripts/webkitpy/bindings/main.py (right):

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:133: def listfiles(directory):
On 2014/09/10 07:39:53, bashi1 wrote:
> listfiles -> list_files

Done.

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:198: def no_excess_files():
On 2014/09/10 07:39:53, bashi1 wrote:
> You call listfiles() twice here. Maybe good to store the result in a local
> variable.

Done.

https://codereview.chromium.org/557203002/diff/30001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:217: def makedir(path):
On 2014/09/10 07:39:53, bashi1 wrote:
> Use os.path.exists() and os.makedirs().
> 
> if not os.path.exists(path):
>   os.makedirs(path)
> 
> And maybe inline.

Done.

[tasak, 2014-09-10 08:32:34]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-09-10 08:33:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tasak@google.com/557203002/40001

[commit-bot: I haz the power, 2014-09-10 09:37:39]

Committed patchset #3 (id:40001) as 181720