Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/test/webdriver/session.h

Issue 5572001: Send screenshots back to the client for debugging (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: need to push again to make sure rietveld didn't screw up Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/server.cc ('k') | chrome/test/webdriver/session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/session.h
diff --git a/chrome/test/webdriver/session.h b/chrome/test/webdriver/session.h
index 88742c41562a0df8392ffe35c32b1ccaa82897b6..ea217b9234acbb2ddbce12767f0c7cc7f5667308 100644
--- a/chrome/test/webdriver/session.h
+++ b/chrome/test/webdriver/session.h
@@ -98,6 +98,7 @@ class Session {
bool GetURL(GURL* url);
bool GetURL(std::string* url);
bool GetTabTitle(std::string* tab_title);
+ bool GetScreenShot(std::string* png);
bool GetCookies(const std::string& url, ListValue** cookies);
bool GetCookiesDeprecated(const GURL& url, std::string* cookies);
@@ -194,18 +195,20 @@ class Session {
// Waits for all tabs to stop loading. Returns true on success.
bool WaitForAllTabsToStopLoading();
- inline const std::string& id() const { return id_; }
+ const std::string& id() const;
- inline int implicit_wait() const { return implicit_wait_; }
- inline void set_implicit_wait(const int& timeout) {
- implicit_wait_ = timeout > 0 ? timeout : 0;
- }
+ int implicit_wait() const;
+ void set_implicit_wait(const int& timeout);
enum Speed { kSlow, kMedium, kFast, kUnknown };
- inline Speed speed() { return speed_; }
- inline void set_speed(Speed speed) {
- speed_ = speed;
- }
+ Speed speed() const;
+ void set_speed(Speed speed);
+
+ // Since screenshots can be very large when in base64 PNG format; the
+ // client is allowed to dyamically enable/disable screenshots on error
+ // during the lifetime of the session.
+ bool screenshot_on_error() const;
+ void set_screenshot_on_error(bool error);
const FrameId& current_target() const;
@@ -237,6 +240,7 @@ class Session {
base::Thread thread_;
int implicit_wait_;
+ bool screenshot_on_error_;
Speed speed_;
FrameId current_target_;
« no previous file with comments | « chrome/test/webdriver/server.cc ('k') | chrome/test/webdriver/session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698