Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: chrome/test/automation/tab_proxy.cc

Issue 5572001: Send screenshots back to the client for debugging (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: need to push again to make sure rietveld didn't screw up Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | chrome/test/webdriver/automation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/tab_proxy.cc
diff --git a/chrome/test/automation/tab_proxy.cc b/chrome/test/automation/tab_proxy.cc
index 3c5315a23203568c0813736f13a93d1b6981bdda..2eb8dd27a1fa5a70a131150fe829ba5c0dcc7033 100644
--- a/chrome/test/automation/tab_proxy.cc
+++ b/chrome/test/automation/tab_proxy.cc
@@ -12,6 +12,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/common/automation_messages.h"
#include "chrome/common/json_value_serializer.h"
+#include "chrome/test/automation/automation_json_requests.h"
#include "chrome/test/automation/automation_proxy.h"
#include "chrome/test/automation/browser_proxy.h"
#include "googleurl/src/gurl.h"
@@ -746,10 +747,14 @@ bool TabProxy::CaptureEntirePageAsPNG(const FilePath& path) {
if (!is_valid())
return false;
- bool succeeded = false;
- sender_->Send(new AutomationMsg_CaptureEntirePageAsPNG(handle_, path,
- &succeeded));
- return succeeded;
+ int browser_index, tab_index;
+ if (!SendGetIndicesFromTabHandleJSONRequest(
+ sender_, handle_, &browser_index, &tab_index)) {
+ return false;
+ }
+
+ return SendCaptureEntirePageJSONRequest(sender_, browser_index,
+ tab_index, path);
}
#if defined(OS_WIN)
« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | chrome/test/webdriver/automation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698