Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/test/webdriver/commands/create_session.cc

Issue 5572001: Send screenshots back to the client for debugging (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: need to push again to make sure rietveld didn't screw up Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/webdriver/commands/command.cc ('k') | chrome/test/webdriver/commands/response.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/webdriver/commands/create_session.h" 5 #include "chrome/test/webdriver/commands/create_session.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 #include <string> 8 #include <string>
9 9
10 #include "base/file_path.h" 10 #include "base/file_path.h"
11 #include "base/values.h" 11 #include "base/values.h"
(...skipping 18 matching lines...) Expand all
30 30
31 // Session manages its own liftime, so do not call delete. 31 // Session manages its own liftime, so do not call delete.
32 Session* session = new Session(); 32 Session* session = new Session();
33 if (!session->Init(session_manager->chrome_dir())) { 33 if (!session->Init(session_manager->chrome_dir())) {
34 SET_WEBDRIVER_ERROR(response, 34 SET_WEBDRIVER_ERROR(response,
35 "Failed to initialize session", 35 "Failed to initialize session",
36 kInternalServerError); 36 kInternalServerError);
37 return; 37 return;
38 } 38 }
39 39
40 bool screenshot_on_error = false;
41 DictionaryValue* capabilities = NULL;
42 if (GetDictionaryParameter("desiredCapabilities", &capabilities)) {
43 capabilities->GetBoolean("takeScreenshotOnError", &screenshot_on_error);
44 session->set_screenshot_on_error(screenshot_on_error);
45 }
46
40 VLOG(1) << "Created session " << session->id(); 47 VLOG(1) << "Created session " << session->id();
41 std::ostringstream stream; 48 std::ostringstream stream;
42 stream << "http://" << session_manager->GetAddress() << "/session/" 49 stream << "http://" << session_manager->GetAddress() << "/session/"
43 << session->id(); 50 << session->id();
44 response->SetStatus(kSeeOther); 51 response->SetStatus(kSeeOther);
45 response->SetValue(Value::CreateStringValue(stream.str())); 52 response->SetValue(Value::CreateStringValue(stream.str()));
46 } 53 }
47 54
48 } // namespace webdriver 55 } // namespace webdriver
OLDNEW
« no previous file with comments | « chrome/test/webdriver/commands/command.cc ('k') | chrome/test/webdriver/commands/response.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698