Start and stop the hotword detector when the user opens/closes the launcher.

Start and stop the hotword detector when the user opens/closes the launcher.

BUG=397019
Committed: https://crrev.com/87d79e63f9fbf7722f6bf73283bcc89431c05a18
Cr-Commit-Position: refs/heads/master@{#294529}

[Anand Mistry (off Chromium), 2014-09-10 03:59:02]

amistry@chromium.org changed reviewers:
+ dbeam@chromium.org, rlp@chromium.org

[rpetterson, 2014-09-10 17:53:31]

https://codereview.chromium.org/557193002/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword/constants.js (right):

https://codereview.chromium.org/557193002/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword/constants.js:91: GOOGLE_COM: 'google.com'
Where are the NTP and GOOGLE_COM ones currently (or will be) used?

[Anand Mistry (off Chromium), 2014-09-10 23:29:42]

https://codereview.chromium.org/557193002/diff/1/chrome/browser/resources/hot...
File chrome/browser/resources/hotword/constants.js (right):

https://codereview.chromium.org/557193002/diff/1/chrome/browser/resources/hot...
chrome/browser/resources/hotword/constants.js:91: GOOGLE_COM: 'google.com'
On 2014/09/10 17:53:31, rpetterson wrote:
> Where are the NTP and GOOGLE_COM ones currently (or will be) used?

They're not used in this change, so I've removed them and will add them back
when I need to. They will be used when I do the google.com/ntp integration.

[rpetterson, 2014-09-11 17:44:40]

lgtm

[Dan Beam, 2014-09-11 17:56:24]

lgtm w/nits

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/constants.js (right):

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/constants.js:92: 
general nit: we use 1 \n between top-level members in chrome code (instead of
closure-style code which is 2 \n)

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/state_manager.js (right):

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/state_manager.js:242: startSession:
function(source, started_cb) {
jsVarsLikeThis (not_like_cpp_vars)

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/state_manager.js:245: if (this.hotwordStatus_)
nit: maybe put

  if (!this.hotwordStatus_)
    return;

at the beginning of updateStateFromStatus_() and just call it here and on L258
always?

[Anand Mistry (off Chromium), 2014-09-12 00:43:33]

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/constants.js (right):

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/constants.js:92: 
On 2014/09/11 17:56:23, Dan Beam wrote:
> general nit: we use 1 \n between top-level members in chrome code (instead of
> closure-style code which is 2 \n)

Fixed for the whole file.

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/hotword/state_manager.js (right):

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/state_manager.js:242: startSession:
function(source, started_cb) {
On 2014/09/11 17:56:23, Dan Beam wrote:
> jsVarsLikeThis (not_like_cpp_vars)

Done.

https://codereview.chromium.org/557193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/hotword/state_manager.js:245: if (this.hotwordStatus_)
On 2014/09/11 17:56:24, Dan Beam wrote:
> nit: maybe put
> 
>   if (!this.hotwordStatus_)
>     return;
> 
> at the beginning of updateStateFromStatus_() and just call it here and on L258
> always?

Done.

[Anand Mistry (off Chromium), 2014-09-12 00:43:40]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2014-09-12 00:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/557193002/40001

[commit-bot: I haz the power, 2014-09-12 02:37:19]

Committed patchset #3 (id:40001) as 5246893c45c2590f8d532b863e3cf3b819066d0c

[commit-bot: I haz the power, 2014-09-12 02:42:40]

Patchset 3 (id:??) landed as
https://crrev.com/87d79e63f9fbf7722f6bf73283bcc89431c05a18
Cr-Commit-Position: refs/heads/master@{#294529}