Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <!-- | 1 <!-- |
| 2 Copyright 2014 The Chromium Authors. All rights reserved. | 2 Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. | 4 found in the LICENSE file. |
| 5 --> | 5 --> |
| 6 | 6 |
| 7 <script> | 7 <script> |
| 8 function CTFailure(step, reason, resultsByBuilder) { | 8 function CTFailure(step, reason, resultsByBuilder) { |
| 9 this.key = step + '::' + reason; | 9 this.key = step + '::' + reason; |
| 10 this.step = step; | 10 this.step = step; |
| (...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 61 Object.values(this.resultNodesByBuilder, function(result) { | 61 Object.values(this.resultNodesByBuilder, function(result) { |
| 62 annotations.push(result.annotation ? result.annotation : {}); | 62 annotations.push(result.annotation ? result.annotation : {}); |
| 63 }); | 63 }); |
| 64 return annotations; | 64 return annotations; |
| 65 }; | 65 }; |
| 66 | 66 |
| 67 // FIXME: This should just be provided as part of the alerts feed. | 67 // FIXME: This should just be provided as part of the alerts feed. |
| 68 CTFailure.createKey = function(alert) { | 68 CTFailure.createKey = function(alert) { |
| 69 function normalize(str) { | 69 function normalize(str) { |
| 70 str = str == null ? '' : String(str); | 70 str = str == null ? '' : String(str); |
| 71 return str.replace(/:/g, '_'); | 71 return str.replace(':', '_'); |
|
esprehn
2014/09/10 02:40:23
This doesn't do the same thing, it used to replace
| |
| 72 } | 72 } |
| 73 return [alert.master_url, alert.builder_name, alert.failing_build, alert.step_ name, alert.reason].map(normalize).join('::'); | 73 return [alert.master_url, alert.builder_name, alert.failing_build, alert.step_ name, alert.reason].map(normalize).join('::'); |
| 74 } | 74 } |
| 75 </script> | 75 </script> |
| OLD | NEW |