Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 557143002: Fix ascii art escaping. (Closed)

Created:
6 years, 3 months ago by M-A Ruel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, jsbell
Project:
tools
Visibility:
Public.

Description

Fix ascii art escaping. This was done because a line ending with a '\' will not be printed properly. Completely escape the string. R=stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291906

Patch Set 1 #

Patch Set 2 : Remove extraneous """ #

Total comments: 2

Patch Set 3 : Made a list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M git_cl.py View 1 2 1 chunk +19 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
M-A Ruel
6 years, 3 months ago (2014-09-10 00:47:20 UTC) #1
ghost stip (do not use)
https://chromiumcodereview.appspot.com/557143002/diff/20001/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/557143002/diff/20001/git_cl.py#newcode2780 git_cl.py:2780: print( make this a list of lines and do ...
6 years, 3 months ago (2014-09-10 00:54:43 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/557143002/diff/20001/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/557143002/diff/20001/git_cl.py#newcode2780 git_cl.py:2780: print( On 2014/09/10 00:54:43, stip wrote: > make this ...
6 years, 3 months ago (2014-09-10 01:06:49 UTC) #3
ghost stip (do not use)
lgtm
6 years, 3 months ago (2014-09-10 02:27:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/557143002/40001
6 years, 3 months ago (2014-09-10 11:06:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 11:08:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 291906

Powered by Google App Engine
This is Rietveld 408576698