Issue 55713002: drive: Use base_name recovered from trashed DB when DB corruption happens

Issue 55713002: drive: Use base_name recovered from trashed DB when DB corruption happens (Closed)

Created:
7 years, 1 month ago by hashimoto

Modified:
7 years, 1 month ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Use title recovered from trashed DB when DB corruption happens Add ResourceMetadataStorage::RecoveredCacheInfo Recover title in ResourceMetadataStorage::RecoverCacheInfoFromTrashedResourceMap Use title in FileCache::RecoverFilesFromCacheDirectory BUG=277333 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232980

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : Use title #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -42 lines)			Patch
M	chrome/browser/chromeos/drive/drive_integration_service.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.cc	View	1 2	3 chunks	+19 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View	1 2	1 chunk	+23 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage.h	View	1 2	2 chunks	+13 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage.cc	View	1 2	3 chunks	+21 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc	View	1 2	2 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

hashimoto

On 2013/11/05 04:17:02, kinaba wrote: > Couldn't we use the 'title' attribute rather 'base_name'? Sounds ...

7 years, 1 month ago (2013-11-05 06:14:23 UTC) #3

kinaba

On 2013/11/05 07:23:30, kinaba wrote: > lgtm Please update the CL title as well

7 years, 1 month ago (2013-11-05 07:23:59 UTC) #5

hashimoto

On 2013/11/05 07:23:59, kinaba wrote: > On 2013/11/05 07:23:30, kinaba wrote: > > lgtm > ...

7 years, 1 month ago (2013-11-05 07:28:53 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/55713002/140001

7 years, 1 month ago (2013-11-05 08:53:51 UTC) #7

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219518

7 years, 1 month ago (2013-11-05 10:38:59 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/55713002/140001

7 years, 1 month ago (2013-11-05 10:42:19 UTC) #9

Message was sent while issue was closed.

Change committed as 232980

Expand Messages | Collapse Messages