Issue 557123005: [turbofan] Lower JSStoreProperty during JS typed lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 557123005: [turbofan] Lower JSStoreProperty during JS typed lowering. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Lower JSStoreProperty during JS typed lowering. Note that we cannot yet emit a diamond here (patch is ready), because the scheduler is still broken wrt. free floating control (seems related although this diamond is not free floating). TEST=cctest R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23838

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -16 lines)			Patch
M	src/compiler/js-typed-lowering.h	View	2 chunks	+13 lines, -10 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View	4 chunks	+51 lines, -6 lines	0 comments	Download
M	test/cctest/compiler/test-run-properties.cc	View	1 chunk	+68 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 3 months ago (2014-09-10 12:29:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23838 (presubmit successful).

Expand Messages | Collapse Messages