Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Issue 557103003: Reverse the order of GN's cycle printing. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reverse the order of GN's cycle printing. When printing dependency cycles, the old meticulously walked the list backwards and explained that this was because the list was in the reverse order of the dependencies. This is wrong, the list is in the normal forward direction and doing that prints out the reverse cycle which is very confusing. Reverse the order of printing to get the correct cycle. Committed: https://crrev.com/5f42d9b7b286f30e793f0d57f814f281db232844 Cr-Commit-Position: refs/heads/master@{#294436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/gn/builder.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
6 years, 3 months ago (2014-09-11 17:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557103003/1
6 years, 3 months ago (2014-09-11 17:40:43 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-11 17:40:44 UTC) #6
jamesr
lgtm
6 years, 3 months ago (2014-09-11 18:10:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557103003/1
6 years, 3 months ago (2014-09-11 18:19:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as a6a75ac6c4a9440c8dc9c67569c7520db0fe7ee5
6 years, 3 months ago (2014-09-11 18:55:34 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:09:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f42d9b7b286f30e793f0d57f814f281db232844
Cr-Commit-Position: refs/heads/master@{#294436}

Powered by Google App Engine
This is Rietveld 408576698