Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 557103002: Remove renamed applyScrollAndScale after removing uses in Chromium. (Closed)

Created:
6 years, 3 months ago by bokan
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove renamed applyScrollAndScale after removing uses in Chromium. https://codereview.chromium.org/511253003/ replaced applyScrollAndScale with applyViewportDeltas. This method can now be removed from the Blink API. BUG=333143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M public/web/WebWidget.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bokan
+jamesr@, third side of the patch to remove now unused API method.
6 years, 3 months ago (2014-09-09 21:57:43 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-09 22:02:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/557103002/1
6 years, 3 months ago (2014-09-09 22:07:53 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 23:08:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181685

Powered by Google App Engine
This is Rietveld 408576698