Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 557033002: Add string_number_conversion and its test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add string_number_conversion and its test. This includes the StringToNumber() function, both int and unsigned int variants. Similar functionality is available in base, but it is unsuitable for applications where a number’s base may be determined based on an "0x" or "0X" prefix (hexadecimal) or an "0" prefix (octal). TEST=util_test StringNumberConversion.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/10d1b76b90b23463c22bf8d06a3f93781e48d2e2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -0 lines) Patch
A util/stdlib/string_number_conversion.h View 1 chunk +63 lines, -0 lines 0 comments Download
A util/stdlib/string_number_conversion.cc View 1 chunk +157 lines, -0 lines 0 comments Download
A util/stdlib/string_number_conversion_test.cc View 1 chunk +218 lines, -0 lines 1 comment Download
M util/util.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-09 20:50:06 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/557033002/diff/1/util/stdlib/string_number_conversion_test.cc File util/stdlib/string_number_conversion_test.cc (right): https://codereview.chromium.org/557033002/diff/1/util/stdlib/string_number_conversion_test.cc#newcode35 util/stdlib/string_number_conversion_test.cc:35: {"2147483647", true, std::numeric_limits<int>::max()}, This is going to fail ...
6 years, 3 months ago (2014-09-10 16:56:54 UTC) #3
Mark Mentovai
We’ll deal. :)
6 years, 3 months ago (2014-09-10 19:29:45 UTC) #4
Mark Mentovai
6 years, 3 months ago (2014-09-10 19:30:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 10d1b76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698