Revert "Don't layout when isSelfPaintingLayer() changes"

Revert "Don't layout when isSelfPaintingLayer() changes"

This reverts https://src.chromium.org/viewvc/blink?revision=173614&view=revision

Breaks going in and out of compositing mode for layers that are floated. There
is logic that is reading the self painting layer bit when computing the overflow
of elements inside layout and also when computing if floats should paint. My
original patch was generally wrong, so many parts of layout are reading
hasSelfPaintingLayer() inside layout.

BUG=411825
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181676

[esprehn, 2014-09-09 20:19:20]

esprehn@chromium.org changed reviewers:
+ abarth@chromium.org, chrishtr@chromium.org

[esprehn, 2014-09-09 20:19:21]

My original patch was just wrong, I'll add the rotation test after this revert
lands. In general there's tons of code that reads hasSelfPaintingLayer() inside
layout and caches state differently because of it which is surprising since I
had assumed it was a paint concept, but it looks like maybe callers are using it
to indicate things like positioning and other concepts. (ex. the line box tree,
floats, visual overflow all depend on this state).

[esprehn, 2014-09-09 20:20:14]

Sorry I meant the simplified transform test, it's pretty easy to trigger the
bugs I caused.

[chrishtr, 2014-09-09 20:24:56]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2014-09-09 20:24:57]

lgtm

[abarth-chromium, 2014-09-09 20:25:03]

The CQ bit was checked by abarth@chromium.org

[abarth-chromium, 2014-09-09 20:25:04]

lgtm

[commit-bot: I haz the power, 2014-09-09 20:25:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/esprehn@chromium.org/556993002/1

[commit-bot: I haz the power, 2014-09-09 21:28:36]

Committed patchset #1 (id:1) as 181676