Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Issue 556973003: cc: Invalidate all new recorded pixels when a layer grows. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Invalidate all new recorded pixels when a layer grows. Previously we invalidated only new recorded pixels on tiles that resized but ignored new recording tiles. The problem with this is that if the old layer size is on the boundary of recording tiles, then we invalidate nothing. But there may be raster tiles that would like to use the new recording tiles, and currently have uninitialized content in them, but they don't get invalidated to hear about it. R=vmpstr BUG=411774 Committed: https://crrev.com/d0a11b12e7fcc37409d2fcb35c8a59f44d82b5d5 Cr-Commit-Position: refs/heads/master@{#294203}

Patch Set 1 #

Total comments: 2

Patch Set 2 : invalidateraster: review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -28 lines) Patch
M cc/resources/picture_pile.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M cc/resources/picture_pile_unittest.cc View 1 6 chunks +53 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
danakj
6 years, 3 months ago (2014-09-09 22:24:08 UTC) #1
vmpstr
lgtm. Thanks for tracking this down. https://codereview.chromium.org/556973003/diff/1/cc/resources/picture_pile_unittest.cc File cc/resources/picture_pile_unittest.cc (right): https://codereview.chromium.org/556973003/diff/1/cc/resources/picture_pile_unittest.cc#newcode475 cc/resources/picture_pile_unittest.cc:475: // We invalidated ...
6 years, 3 months ago (2014-09-09 22:43:00 UTC) #2
danakj
Thanks! https://codereview.chromium.org/556973003/diff/1/cc/resources/picture_pile_unittest.cc File cc/resources/picture_pile_unittest.cc (right): https://codereview.chromium.org/556973003/diff/1/cc/resources/picture_pile_unittest.cc#newcode475 cc/resources/picture_pile_unittest.cc:475: // We invalidated any new pixels. On 2014/09/09 ...
6 years, 3 months ago (2014-09-10 16:52:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/556973003/20001
6 years, 3 months ago (2014-09-10 16:52:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/12214)
6 years, 3 months ago (2014-09-10 18:11:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/556973003/20001
6 years, 3 months ago (2014-09-10 18:22:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5bef4a0ed8bf61340f8c60c7e3febc01227ce6ce
6 years, 3 months ago (2014-09-10 19:03:08 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 19:19:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0a11b12e7fcc37409d2fcb35c8a59f44d82b5d5
Cr-Commit-Position: refs/heads/master@{#294203}

Powered by Google App Engine
This is Rietveld 408576698