third_party/protobuf/README.chromium - Issue 556933002: Remove protobuf lite for java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/README.chromium

Issue 556933002: Remove protobuf lite for java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase before submit Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/README.chromium

diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium

index a52aef8fe950a4cfde40418c2a17b2f6dacdc02c..b6ccf575c69534371db652c8f4d95ce2a3df43db 100644

--- a/third_party/protobuf/README.chromium

+++ b/third_party/protobuf/README.chromium

@@ -11,8 +11,6 @@ Local files (not taken from upstream):

README.chromium

config.h

descriptor2_pb.py

-protobuf_lite_java_descriptor_proto.py

-protobuf_lite_java_parse_pom.py

A protobuf.gyp file has been added for building with Chromium.

@@ -35,12 +33,3 @@ Revision 523 was cherry-picked from upstream.

Revision 524 was cherry-picked from upstream.

Revision 573 was cherry-picked from upstream.

The `&file->options() != NULL &&` was removed from descriptor.cc

-Notes about Java:

-We have not forked the Java version of protobuf-lite, so the Java version does

-not support unknown field retention.

-The list of Java files included in the lite profile for Java is parsed from the

-maven java/pom.xml by the script protobuf_lite_java_parse_pom.py. See

-'javac_includes' variable in protobuf_lite_javalib GYP target.