Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 556893004: [Android] Add JUnit4 to third_party/junit/. (Closed)

Created:
6 years, 3 months ago by jbudorick
Modified:
6 years, 3 months ago
CC:
chromium-reviews, navabi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Add JUnit4 to third_party/junit/. This CL adds JUnit4 to chromium android checkouts. It will be used for host-side java unit testing. This should allow us to both write new tests for existing java code and convert some existing device-side instrumentation tests. BUG=316383 Committed: https://crrev.com/c96b36794250cc0e14cc7d9aac882a394bfd5a62 Cr-Commit-Position: refs/heads/master@{#294966}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Pull LICENSE up from src #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -0 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/junit/LICENSE View 1 2 3 1 chunk +218 lines, -0 lines 0 comments Download
A third_party/junit/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/junit/README.chromium View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
jbudorick
6 years, 3 months ago (2014-09-09 18:25:34 UTC) #2
jbudorick
6 years, 3 months ago (2014-09-09 18:25:56 UTC) #3
klundberg
lgtm
6 years, 3 months ago (2014-09-09 18:50:33 UTC) #4
jbudorick
OSPTR gave out-of-band lgtm
6 years, 3 months ago (2014-09-15 17:42:28 UTC) #5
navabi
lgtm
6 years, 3 months ago (2014-09-15 17:52:33 UTC) #7
jbudorick
+brettw, cpu for alternative OWNERS review ptal
6 years, 3 months ago (2014-09-15 19:43:20 UTC) #9
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-15 23:17:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556893004/60001
6 years, 3 months ago (2014-09-15 23:32:16 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001) as d11cffb0009942033f67f74d7eb029c432596ca5
6 years, 3 months ago (2014-09-16 01:36:35 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 01:39:03 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c96b36794250cc0e14cc7d9aac882a394bfd5a62
Cr-Commit-Position: refs/heads/master@{#294966}

Powered by Google App Engine
This is Rietveld 408576698