Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: Source/bindings/scripts/v8_methods.py

Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 'function_template': function_template(), 157 'function_template': function_template(),
158 'has_custom_registration': is_static or 158 'has_custom_registration': is_static or
159 v8_utilities.has_extended_attribute( 159 v8_utilities.has_extended_attribute(
160 method, CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES), 160 method, CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES),
161 'has_exception_state': 161 'has_exception_state':
162 is_raises_exception or 162 is_raises_exception or
163 is_check_security_for_frame or 163 is_check_security_for_frame or
164 is_check_security_for_window or 164 is_check_security_for_window or
165 any(argument for argument in arguments 165 any(argument for argument in arguments
166 if argument.idl_type.name == 'SerializedScriptValue' or 166 if argument.idl_type.name == 'SerializedScriptValue' or
167 argument.idl_type.may_raise_exception_on_conversion), 167 argument.idl_type.v8_conversion_needs_exception_state),
168 'idl_type': idl_type.base_type, 168 'idl_type': idl_type.base_type,
169 'is_call_with_execution_context': has_extended_attribute_value(method, ' CallWith', 'ExecutionContext'), 169 'is_call_with_execution_context': has_extended_attribute_value(method, ' CallWith', 'ExecutionContext'),
170 'is_call_with_script_arguments': is_call_with_script_arguments, 170 'is_call_with_script_arguments': is_call_with_script_arguments,
171 'is_call_with_script_state': is_call_with_script_state, 171 'is_call_with_script_state': is_call_with_script_state,
172 'is_check_security_for_frame': is_check_security_for_frame, 172 'is_check_security_for_frame': is_check_security_for_frame,
173 'is_check_security_for_node': is_check_security_for_node, 173 'is_check_security_for_node': is_check_security_for_node,
174 'is_check_security_for_window': is_check_security_for_window, 174 'is_check_security_for_window': is_check_security_for_window,
175 'is_custom': 'Custom' in extended_attributes, 175 'is_custom': 'Custom' in extended_attributes,
176 'is_custom_element_callbacks': is_custom_element_callbacks, 176 'is_custom_element_callbacks': is_custom_element_callbacks,
177 'is_do_not_check_security': is_do_not_check_security, 177 'is_do_not_check_security': is_do_not_check_security,
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 if argument.idl_type.is_dictionary: 450 if argument.idl_type.is_dictionary:
451 # We always create impl objects for IDL dictionaries. 451 # We always create impl objects for IDL dictionaries.
452 return '%s::create()' % argument.idl_type.base_type 452 return '%s::create()' % argument.idl_type.base_type
453 if not argument.default_value: 453 if not argument.default_value:
454 return None 454 return None
455 return argument.idl_type.literal_cpp_value(argument.default_value) 455 return argument.idl_type.literal_cpp_value(argument.default_value)
456 456
457 IdlTypeBase.union_arguments = None 457 IdlTypeBase.union_arguments = None
458 IdlUnionType.union_arguments = property(union_arguments) 458 IdlUnionType.union_arguments = property(union_arguments)
459 IdlArgument.default_cpp_value = property(argument_default_cpp_value) 459 IdlArgument.default_cpp_value = property(argument_default_cpp_value)
OLDNEW
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698