Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 556873004: Battery Status API: add UMA logging for Windows. (Closed)

Created:
6 years, 3 months ago by timvolodine
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Battery Status API: add UMA logging for Windows. Adds UMA logging to track if any batteries were present at the start of Battery Status API. BUG= Committed: https://crrev.com/cbeee75bd0fcae4c97e2ad2629053a53da14e940 Cr-Commit-Position: refs/heads/master@{#296278}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix Ilya's comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M content/browser/battery_status/battery_status_manager_win.cc View 1 3 chunks +33 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
timvolodine
one more platform..
6 years, 3 months ago (2014-09-12 15:17:01 UTC) #2
Ilya Sherman
Histograms LGTM % a suggestion: https://codereview.chromium.org/556873004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/556873004/diff/1/tools/metrics/histograms/histograms.xml#newcode38097 tools/metrics/histograms/histograms.xml:38097: + <int value="2" label="Unknown"/> ...
6 years, 3 months ago (2014-09-12 19:32:58 UTC) #3
Michael van Ouwerkerk
lgtm
6 years, 3 months ago (2014-09-15 12:17:58 UTC) #4
timvolodine
https://codereview.chromium.org/556873004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/556873004/diff/1/tools/metrics/histograms/histograms.xml#newcode38097 tools/metrics/histograms/histograms.xml:38097: + <int value="2" label="Unknown"/> On 2014/09/12 19:32:58, Ilya Sherman ...
6 years, 3 months ago (2014-09-23 19:04:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/556873004/40001
6 years, 3 months ago (2014-09-23 21:59:10 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 3e1354763012982654f991434433e637a5acd1f2
6 years, 3 months ago (2014-09-23 22:07:12 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 22:07:49 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cbeee75bd0fcae4c97e2ad2629053a53da14e940
Cr-Commit-Position: refs/heads/master@{#296278}

Powered by Google App Engine
This is Rietveld 408576698