Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 556853003: Hard-code the symbolizer path in asan_symbolize.py (Closed)

Created:
6 years, 3 months ago by earthdok
Modified:
6 years, 3 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hard-code the symbolizer path in asan_symbolize.py BUG=415179 R=glider@chromium.org NOTRY=true Committed: https://crrev.com/8f3aad074241dd60f5a8b6796866ec1272ea3877 Cr-Commit-Position: refs/heads/master@{#295967}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : assert that file exists #

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/valgrind/asan/asan_symbolize.py View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
earthdok
6 years, 3 months ago (2014-09-17 18:44:29 UTC) #1
earthdok
On 2014/09/17 18:44:29, earthdok wrote: ping?
6 years, 3 months ago (2014-09-18 14:51:01 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/556853003/diff/1/tools/valgrind/asan/asan_symbolize.py File tools/valgrind/asan/asan_symbolize.py (right): https://codereview.chromium.org/556853003/diff/1/tools/valgrind/asan/asan_symbolize.py#newcode48 tools/valgrind/asan/asan_symbolize.py:48: # Assuming this script resides in src/tools/valgrind/asan. Can you ...
6 years, 3 months ago (2014-09-19 13:08:06 UTC) #3
Alexander Potapenko
On 2014/09/19 13:08:06, Alexander Potapenko wrote: > https://codereview.chromium.org/556853003/diff/1/tools/valgrind/asan/asan_symbolize.py > File tools/valgrind/asan/asan_symbolize.py (right): > > https://codereview.chromium.org/556853003/diff/1/tools/valgrind/asan/asan_symbolize.py#newcode48 ...
6 years, 3 months ago (2014-09-19 13:20:44 UTC) #4
earthdok
On 2014/09/19 13:08:06, Alexander Potapenko wrote: > https://codereview.chromium.org/556853003/diff/1/tools/valgrind/asan/asan_symbolize.py > File tools/valgrind/asan/asan_symbolize.py (right): > > https://codereview.chromium.org/556853003/diff/1/tools/valgrind/asan/asan_symbolize.py#newcode48 ...
6 years, 3 months ago (2014-09-22 14:29:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/556853003/60001
6 years, 3 months ago (2014-09-22 14:32:08 UTC) #7
Alexander Potapenko
On 2014/09/22 14:29:05, earthdok wrote: > On 2014/09/19 13:08:06, Alexander Potapenko wrote: > > > ...
6 years, 3 months ago (2014-09-22 14:32:22 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as bbd7e8d6d2bd21d82a02b01a9bbd77fedf792041
6 years, 3 months ago (2014-09-22 14:32:27 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 14:33:01 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8f3aad074241dd60f5a8b6796866ec1272ea3877
Cr-Commit-Position: refs/heads/master@{#295967}

Powered by Google App Engine
This is Rietveld 408576698