Added value to ServiceUtilityProcessHostEventType to track when utility process failed to start.

Added value to ServiceUtilityProcessHostEventType to track when utility process failed to start.

BUG=408184
TBR=asvitkine@chromium.org

Committed: https://crrev.com/061600988661865e838fbbf72f45af294a4b70c2
Cr-Commit-Position: refs/heads/master@{#295030}

[Vitaly Buka (NO REVIEWS), 2014-09-16 01:26:07]

vitalybuka@chromium.org changed reviewers:
+ thestig@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-09-16 01:26:44]

I'd like to submit this as separate patch to be able to merge into beta.

[Vitaly Buka (NO REVIEWS), 2014-09-16 01:27:32]

vitalybuka@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Lei Zhang, 2014-09-16 01:28:54]

lgtm

[Vitaly Buka (NO REVIEWS), 2014-09-16 07:57:32]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-16 07:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/556823004/1

[commit-bot: I haz the power, 2014-09-16 08:40:19]

Committed patchset #1 (id:1) as d79c54e88c7a639dd1912fb4db8e719abc2da55d

[commit-bot: I haz the power, 2014-09-16 08:41:35]

Patchset 1 (id:??) landed as
https://crrev.com/061600988661865e838fbbf72f45af294a4b70c2
Cr-Commit-Position: refs/heads/master@{#295030}

[Alexei Svitkine (slow), 2014-09-16 13:17:41]

LGTM I guess, but please address my comment below in a follow-up CL.

Also, please don't TBR histogram changes in the future.

https://codereview.chromium.org/556823004/diff/1/chrome/service/service_utili...
File chrome/service/service_utility_process_host.cc (right):

https://codereview.chromium.org/556823004/diff/1/chrome/service/service_utili...
chrome/service/service_utility_process_host.cc:192:
SERVICE_UTILITY_FAILED_TO_START,
Can you make a helper function to log this histogram that takes the enum value
as a param?

Each macro expands to a non-trivial amount of code, so doing so will avoid extra
bloat to the binary.

[Vitaly Buka (NO REVIEWS), 2014-09-16 18:53:08]

On 2014/09/16 13:17:41, Alexei Svitkine wrote:
> LGTM I guess, but please address my comment below in a follow-up CL.
> 
> Also, please don't TBR histogram changes in the future.

Ok. Sorry for that.

> 
>
https://codereview.chromium.org/556823004/diff/1/chrome/service/service_utili...
> File chrome/service/service_utility_process_host.cc (right):
> 
>
https://codereview.chromium.org/556823004/diff/1/chrome/service/service_utili...
> chrome/service/service_utility_process_host.cc:192:
> SERVICE_UTILITY_FAILED_TO_START,
> Can you make a helper function to log this histogram that takes the enum value
> as a param?
> 
> Each macro expands to a non-trivial amount of code, so doing so will avoid
extra
> bloat to the binary.

Done in https://codereview.chromium.org/576823002/