Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp

Issue 556823003: Revert "Revert of [oilpan]: optimize the way we allocate persistent handles in wrappers. (patchset … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 void V8ArrayBuffer::refObject(ScriptWrappableBase* internalPointer) 66 void V8ArrayBuffer::refObject(ScriptWrappableBase* internalPointer)
67 { 67 {
68 toImpl(internalPointer)->ref(); 68 toImpl(internalPointer)->ref();
69 } 69 }
70 70
71 void V8ArrayBuffer::derefObject(ScriptWrappableBase* internalPointer) 71 void V8ArrayBuffer::derefObject(ScriptWrappableBase* internalPointer)
72 { 72 {
73 toImpl(internalPointer)->deref(); 73 toImpl(internalPointer)->deref();
74 } 74 }
75 75
76 PersistentNode* V8ArrayBuffer::createPersistentHandle(ScriptWrappableBase* inter nalPointer) 76 WrapperPersistentNode* V8ArrayBuffer::createPersistentHandle(ScriptWrappableBase * internalPointer)
77 { 77 {
78 ASSERT_NOT_REACHED(); 78 ASSERT_NOT_REACHED();
79 return 0; 79 return 0;
80 } 80 }
81 81
82 v8::Handle<v8::Object> V8ArrayBuffer::createWrapper(PassRefPtr<ArrayBuffer> impl , v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) 82 v8::Handle<v8::Object> V8ArrayBuffer::createWrapper(PassRefPtr<ArrayBuffer> impl , v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
83 { 83 {
84 ASSERT(impl.get()); 84 ASSERT(impl.get());
85 ASSERT(!DOMDataStore::containsWrapper<V8ArrayBuffer>(impl.get(), isolate)); 85 ASSERT(!DOMDataStore::containsWrapper<V8ArrayBuffer>(impl.get(), isolate));
86 86
(...skipping 27 matching lines...) Expand all
114 return V8ArrayBuffer::hasInstance(value, isolate) ? V8ArrayBuffer::toImpl(v8 ::Handle<v8::Object>::Cast(value)) : 0; 114 return V8ArrayBuffer::hasInstance(value, isolate) ? V8ArrayBuffer::toImpl(v8 ::Handle<v8::Object>::Cast(value)) : 0;
115 } 115 }
116 116
117 template<> 117 template<>
118 v8::Handle<v8::Value> toV8NoInline(ArrayBuffer* impl, v8::Handle<v8::Object> cre ationContext, v8::Isolate* isolate) 118 v8::Handle<v8::Value> toV8NoInline(ArrayBuffer* impl, v8::Handle<v8::Object> cre ationContext, v8::Isolate* isolate)
119 { 119 {
120 return toV8(impl, creationContext, isolate); 120 return toV8(impl, creationContext, isolate);
121 } 121 }
122 122
123 } // namespace blink 123 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/custom/V8ArrayBufferCustom.h ('k') | Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698