Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 556823002: [turbofan] ARM64 branch selector additions (Closed)

Created:
6 years, 3 months ago by m.m.capewell
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM64 branch selector additions Add support for selecting Cmp and Cmn instructions, and tests for branching on the result of arithmetic or logical operations. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -0 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64-unittest.cc View 5 chunks +199 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
m.m.capewell
6 years, 3 months ago (2014-09-09 12:11:45 UTC) #2
Benedikt Meurer
LGTM
6 years, 3 months ago (2014-09-09 13:04:29 UTC) #3
m.m.capewell
6 years, 3 months ago (2014-09-09 14:13:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698