Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 556803002: [SyncFS] Drop TaskRunner in MetadataDatabase (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Drop TaskRunner in MetadataDatabase Drop TaskRunner in MetadataDatabase, that is no longer needed. BUG=412367 Committed: https://crrev.com/facf66e09bf863b599aba759db25df02dbafff23 Cr-Commit-Position: refs/heads/master@{#293937}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -186 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 53 chunks +23 lines, -176 lines 2 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tzik
PTL
6 years, 3 months ago (2014-09-09 10:15:51 UTC) #2
peria
https://codereview.chromium.org/556803002/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.cc File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right): https://codereview.chromium.org/556803002/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.cc#newcode1322 chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1322: const CreateCallback& callback) { I think we can merge ...
6 years, 3 months ago (2014-09-09 10:29:34 UTC) #3
peria
lgtm https://codereview.chromium.org/556803002/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.cc File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right): https://codereview.chromium.org/556803002/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.cc#newcode1322 chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1322: const CreateCallback& callback) { Please ignore the previous ...
6 years, 3 months ago (2014-09-09 10:32:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/556803002/1
6 years, 3 months ago (2014-09-09 11:25:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/556803002/1
6 years, 3 months ago (2014-09-09 13:58:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as a5285f03d1bd8dd0021209ef16b6440581ec2f87
6 years, 3 months ago (2014-09-09 14:20:15 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/facf66e09bf863b599aba759db25df02dbafff23
Cr-Commit-Position: refs/heads/master@{#293937}

Powered by Google App Engine
This is Rietveld 408576698