Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 556793006: Add PluginPlaceholderElement.js to Blink platform resources. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by jbroman
Modified:
2 years, 8 months ago
Reviewers:
jochen
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add PluginPlaceholderElement.js to Blink platform resources. This prepares for the landing of https://codereview.chromium.org/522783002/ which now requires a three-sided change due to changes in how Blink accesses private script resources. Part 1: https://codereview.chromium.org/570863002/ BUG=364716 Committed: https://crrev.com/7424a1b1582d06cee76e259080c2062e299662fa Cr-Commit-Position: refs/heads/master@{#294884}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
jbroman
2 years, 8 months ago (2014-09-15 12:59:24 UTC) #2
jochen
lgtm
2 years, 8 months ago (2014-09-15 14:25:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556793006/1
2 years, 8 months ago (2014-09-15 19:17:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 281a925842612a662c067c504beb25fbe63b55ee
2 years, 8 months ago (2014-09-15 20:32:25 UTC) #6
commit-bot: I haz the power
2 years, 8 months ago (2014-09-15 20:35:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7424a1b1582d06cee76e259080c2062e299662fa
Cr-Commit-Position: refs/heads/master@{#294884}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06