Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 556793004: Fix ManagePasswordsBubbleViewTest.FadeOnKey (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
Reviewers:
Mike West
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ManagePasswordsBubbleViewTest.FadeOnKey The original test failed on XP: manage_passwords_bubble_view_browsertest.cc(68): error: Value of: ManagePasswordsBubbleView::manage_password_bubble()-> IsFadingAway() Actual: false Expected: true BUG=412340 Committed: https://crrev.com/6f1fb8f50b4091e57d7706d5ace974b9969bba10 Cr-Commit-Position: refs/heads/master@{#293962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 2 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vasilii
Hi Mike, please review.
6 years, 3 months ago (2014-09-09 16:54:54 UTC) #2
Mike West
LGTM if the bot's happy.
6 years, 3 months ago (2014-09-09 17:04:28 UTC) #3
vasilii
There is no XP trybot. So we'll know tomorrow if it's happy.
6 years, 3 months ago (2014-09-09 17:14:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/556793004/1
6 years, 3 months ago (2014-09-09 17:17:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2518489ce8ab5b0c235873fb518d9c9c0af885bb
6 years, 3 months ago (2014-09-09 17:45:21 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f1fb8f50b4091e57d7706d5ace974b9969bba10
Cr-Commit-Position: refs/heads/master@{#293962}

Powered by Google App Engine
This is Rietveld 408576698