Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: src/types.h

Issue 556733003: Make type bitsets explicitly unsigned (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/types.h
diff --git a/src/types.h b/src/types.h
index 7d4f6d577ad2811e94b395979ec26fe2cc191a83..df35c9e3346fc59bb024b965d928ae57705be48a 100644
--- a/src/types.h
+++ b/src/types.h
@@ -147,15 +147,15 @@ namespace internal {
#define REPRESENTATION_BITSET_TYPE_LIST(V) \
V(None, 0) \
- V(UntaggedInt1, 1 << 23 | kSemantic) \
- V(UntaggedInt8, 1 << 24 | kSemantic) \
- V(UntaggedInt16, 1 << 25 | kSemantic) \
- V(UntaggedInt32, 1 << 26 | kSemantic) \
- V(UntaggedFloat32, 1 << 27 | kSemantic) \
- V(UntaggedFloat64, 1 << 28 | kSemantic) \
- V(UntaggedPtr, 1 << 29 | kSemantic) \
- V(TaggedInt, 1 << 30 | kSemantic) \
- V(TaggedPtr, 1 << 31 | kSemantic) \
+ V(UntaggedInt1, 1u << 23 | kSemantic) \
+ V(UntaggedInt8, 1u << 24 | kSemantic) \
+ V(UntaggedInt16, 1u << 25 | kSemantic) \
+ V(UntaggedInt32, 1u << 26 | kSemantic) \
+ V(UntaggedFloat32, 1u << 27 | kSemantic) \
+ V(UntaggedFloat64, 1u << 28 | kSemantic) \
+ V(UntaggedPtr, 1u << 29 | kSemantic) \
+ V(TaggedInt, 1u << 30 | kSemantic) \
+ V(TaggedPtr, 1u << 31 | kSemantic) \
\
V(UntaggedInt, kUntaggedInt1 | kUntaggedInt8 | \
kUntaggedInt16 | kUntaggedInt32) \
@@ -165,28 +165,28 @@ namespace internal {
V(Tagged, kTaggedInt | kTaggedPtr)
#define SEMANTIC_BITSET_TYPE_LIST(V) \
- V(Null, 1 << 1 | REPRESENTATION(kTaggedPtr)) \
- V(Undefined, 1 << 2 | REPRESENTATION(kTaggedPtr)) \
- V(Boolean, 1 << 3 | REPRESENTATION(kTaggedPtr)) \
- V(UnsignedSmall, 1 << 4 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(OtherSignedSmall, 1 << 5 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(OtherUnsigned31, 1 << 6 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(OtherUnsigned32, 1 << 7 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(OtherSigned32, 1 << 8 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(MinusZero, 1 << 9 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(NaN, 1 << 10 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(OtherNumber, 1 << 11 | REPRESENTATION(kTagged | kUntaggedNumber)) \
- V(Symbol, 1 << 12 | REPRESENTATION(kTaggedPtr)) \
- V(InternalizedString, 1 << 13 | REPRESENTATION(kTaggedPtr)) \
- V(OtherString, 1 << 14 | REPRESENTATION(kTaggedPtr)) \
- V(Undetectable, 1 << 15 | REPRESENTATION(kTaggedPtr)) \
- V(Array, 1 << 16 | REPRESENTATION(kTaggedPtr)) \
- V(Buffer, 1 << 17 | REPRESENTATION(kTaggedPtr)) \
- V(Function, 1 << 18 | REPRESENTATION(kTaggedPtr)) \
- V(RegExp, 1 << 19 | REPRESENTATION(kTaggedPtr)) \
- V(OtherObject, 1 << 20 | REPRESENTATION(kTaggedPtr)) \
- V(Proxy, 1 << 21 | REPRESENTATION(kTaggedPtr)) \
- V(Internal, 1 << 22 | REPRESENTATION(kTagged | kUntagged)) \
+ V(Null, 1u << 1 | REPRESENTATION(kTaggedPtr)) \
+ V(Undefined, 1u << 2 | REPRESENTATION(kTaggedPtr)) \
+ V(Boolean, 1u << 3 | REPRESENTATION(kTaggedPtr)) \
+ V(UnsignedSmall, 1u << 4 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(OtherSignedSmall, 1u << 5 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(OtherUnsigned31, 1u << 6 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(OtherUnsigned32, 1u << 7 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(OtherSigned32, 1u << 8 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(MinusZero, 1u << 9 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(NaN, 1u << 10 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(OtherNumber, 1u << 11 | REPRESENTATION(kTagged | kUntaggedNumber)) \
+ V(Symbol, 1u << 12 | REPRESENTATION(kTaggedPtr)) \
+ V(InternalizedString, 1u << 13 | REPRESENTATION(kTaggedPtr)) \
+ V(OtherString, 1u << 14 | REPRESENTATION(kTaggedPtr)) \
+ V(Undetectable, 1u << 15 | REPRESENTATION(kTaggedPtr)) \
+ V(Array, 1u << 16 | REPRESENTATION(kTaggedPtr)) \
+ V(Buffer, 1u << 17 | REPRESENTATION(kTaggedPtr)) \
+ V(Function, 1u << 18 | REPRESENTATION(kTaggedPtr)) \
+ V(RegExp, 1u << 19 | REPRESENTATION(kTaggedPtr)) \
+ V(OtherObject, 1u << 20 | REPRESENTATION(kTaggedPtr)) \
+ V(Proxy, 1u << 21 | REPRESENTATION(kTaggedPtr)) \
+ V(Internal, 1u << 22 | REPRESENTATION(kTagged | kUntagged)) \
\
V(SignedSmall, kUnsignedSmall | kOtherSignedSmall) \
V(Signed32, kSignedSmall | kOtherUnsigned31 | kOtherSigned32) \
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698