Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 556733002: GN: Exclude some packages that are not used on CrOS (Closed)

Created:
6 years, 3 months ago by Chris Masone
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn_fixes
Project:
chromium
Visibility:
Public.

Description

GN: Exclude some packages that are not used on CrOS Some packages used in linux builds are not used on CrOS, and indeed are not even installed in the CrOS build chroot. Exclude them so that the GN build doesn't try to run pkg-config on packages that aren't installed. BUG=388412 TEST=Create a target that builds //mojo/public, build with os==chromeos R=brettw Committed: https://crrev.com/c397c15b4db8d22528410af612fa2b154bbdb635 Cr-Commit-Position: refs/heads/master@{#293977}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M build/config/linux/BUILD.gn View 1 3 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Chris Masone
6 years, 3 months ago (2014-09-09 03:42:28 UTC) #1
brettw
lgtm https://codereview.chromium.org/556733002/diff/1/build/config/linux/BUILD.gn File build/config/linux/BUILD.gn (right): https://codereview.chromium.org/556733002/diff/1/build/config/linux/BUILD.gn#newcode113 build/config/linux/BUILD.gn:113: # CrOS doesn't install GTK, gconf or any ...
6 years, 3 months ago (2014-09-09 17:41:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/556733002/20001
6 years, 3 months ago (2014-09-09 17:46:21 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8c7fc8ec246b4ed96a8b067f89a4055574461da1
6 years, 3 months ago (2014-09-09 18:58:59 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:35 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c397c15b4db8d22528410af612fa2b154bbdb635
Cr-Commit-Position: refs/heads/master@{#293977}

Powered by Google App Engine
This is Rietveld 408576698