Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 556723004: Add logging in WebViewImpl::scheduleAnimation (Closed)

Created:
6 years, 3 months ago by brianderson
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add logging in WebViewImpl::scheduleAnimation We need to find the missing setNeedsAnimate. BUG=393331 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181770

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/web/WebViewImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brianderson
ptal
6 years, 3 months ago (2014-09-10 19:49:47 UTC) #2
jamesr
lgtm https://codereview.chromium.org/556723004/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/556723004/diff/1/Source/web/WebViewImpl.cpp#newcode4016 Source/web/WebViewImpl.cpp:4016: WTF_LOG(ScriptedAnimationController, "WebViewImpl::scheduleAnimation: acellerated = %d", isAcceleratedCompositingActive() ? 1 ...
6 years, 3 months ago (2014-09-10 21:23:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/556723004/20001
6 years, 3 months ago (2014-09-10 21:24:38 UTC) #5
Ken Russell (switch to Gerrit)
LGTM too, but we'll have to turn the ScriptedAnimationController logging back on on the bots. ...
6 years, 3 months ago (2014-09-10 22:11:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 22:32:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181770

Powered by Google App Engine
This is Rietveld 408576698