extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc - Issue 556723002: Add delegate to install web_contents helpers for MimeHandlerView.

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Issue 556723002: Add delegate to install web_contents helpers for MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from fsamuel@ Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h ('k') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

index 41e076000f5b74660cef82ba4fa8b7c978f51ee4..47ffb8d90616dbe91e062ddc0be73df8a9fc860b 100644

--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

@@ -8,9 +8,11 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/common/url_constants.h"

+#include "extensions/browser/api/extensions_api_client.h"

#include "extensions/browser/guest_view/guest_view_constants.h"

#include "extensions/browser/guest_view/guest_view_manager.h"

#include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.h"

+#include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h"

#include "extensions/common/feature_switch.h"

#include "extensions/strings/grit/extensions_strings.h"

#include "net/base/url_util.h"

@@ -35,7 +37,9 @@ GuestViewBase* MimeHandlerViewGuest::Create(

MimeHandlerViewGuest::MimeHandlerViewGuest(

content::BrowserContext* browser_context,

int guest_instance_id)

- : GuestView<MimeHandlerViewGuest>(browser_context, guest_instance_id) {

+ : GuestView<MimeHandlerViewGuest>(browser_context, guest_instance_id),

+ delegate_(

+ ExtensionsAPIClient::Get()->CreateMimeHandlerViewGuestDelegate()) {

Fady Samuel 2014/09/09 14:30:29 Perhaps we can pass in "this" into "CreateMimeHand

lazyboy 2014/09/09 15:49:33 Done.

}

MimeHandlerViewGuest::~MimeHandlerViewGuest() {

@@ -94,4 +98,9 @@ void MimeHandlerViewGuest::DidAttachToEmbedder() {

std::string());

}

+void MimeHandlerViewGuest::DidInitialize() {

+ if (delegate_)

+ delegate_->AttachHelpers(web_contents());

Fady Samuel 2014/09/09 14:30:29 If the delegate_ knows about this, then we don't n

lazyboy 2014/09/09 15:49:33 Done.

} // namespace extensions