Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 556713002: Add a missing handle scope to ScriptController::shouldBypassMainWorldCSP (Closed)

Created:
6 years, 3 months ago by haraken
Modified:
6 years, 3 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Project:
blink
Visibility:
Public.

Description

Add a missing handle scope to ScriptController::shouldBypassMainWorldCSP Although I cannot reproduce the crash, as far as I see the crash report, it seems that we are missing a handle scope in ScriptController::shouldBypassMainWorldCSP. BUG=411773 TEST=None, I cannot reproduce Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
haraken
PTAL
6 years, 3 months ago (2014-09-09 01:07:59 UTC) #2
Mike West
LGTM.
6 years, 3 months ago (2014-09-09 06:35:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/556713002/1
6 years, 3 months ago (2014-09-09 06:40:23 UTC) #6
jochen (gone - plz use gerrit)
lgtm, thanks I still wonder why this code path is executed at all
6 years, 3 months ago (2014-09-09 07:50:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26161)
6 years, 3 months ago (2014-09-09 09:33:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/556713002/1
6 years, 3 months ago (2014-09-09 13:36:09 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 14:21:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181647

Powered by Google App Engine
This is Rietveld 408576698