Source/web/WebViewImpl.h - Issue 556703005: Initial draft - modify ViewportAnchor to know about both inner and outer viewports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 556703005: Initial draft - modify ViewportAnchor to know about both inner and outer viewports. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reapplying patch set 11 after a mac test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index 95f6e282d6f2474a3618cd73f63daad92f18617e..9bd645bc390978e790c949b3a815ce030393379c 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -511,6 +511,10 @@ private:

// prevent external usage

virtual void setPageScaleFactor(float scaleFactor, const WebPoint& origin) OVERRIDE;

+ void scrollAndRescaleViewports(float scaleFactor, const IntPoint& mainFrameOrigin, const FloatPoint& pinchViewportOrigin);

+ IntRect visibleRectInDocument() const;

float legibleScale() const;

void refreshPageScaleFactorAfterLayout();

void resumeTreeViewCommits();

« no previous file with comments | « Source/web/ViewportAnchor.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »